Bug 1274727 - Use toString method for search engine identifiers. r=bnicholson draft
authorMichael Comella <michael.l.comella@gmail.com>
Mon, 23 May 2016 15:26:26 -0700
changeset 369849 5750fe71960616ad8014b473c6a5d99c2d3b2dc3
parent 369835 3ff4077f9e4bf923322c95fb7226bc0e9090f898
child 369850 2959b850ee66e19e2dd5ed7cf930f2c2568397a0
push id18935
push usermichael.l.comella@gmail.com
push dateMon, 23 May 2016 22:26:38 +0000
reviewersbnicholson
bugs1274727
milestone49.0a1
Bug 1274727 - Use toString method for search engine identifiers. r=bnicholson These values are what are actually used UI telemetry (perhaps because the enums were added after the strings?). They're also a little less obnoxious than the enum names. MozReview-Commit-ID: K5i2Hr4DR4J
mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
--- a/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
+++ b/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
@@ -2435,17 +2435,17 @@ public class BrowserApp extends GeckoApp
      *
      * @param where where the search was started from
      */
     private static void recordSearch(@NonNull final SharedPreferences prefs, @NonNull final String engineIdentifier,
             @NonNull final TelemetryContract.Method where) {
         // We could include the engine identifier as an extra but we'll
         // just capture that with core ping telemetry (bug 1253319).
         Telemetry.sendUIEvent(TelemetryContract.Event.SEARCH, where);
-        SearchCountMeasurements.incrementSearch(prefs, engineIdentifier, where.name());
+        SearchCountMeasurements.incrementSearch(prefs, engineIdentifier, where.toString());
     }
 
     /**
      * Store search query in SearchHistoryProvider.
      *
      * @param query
      *        a search query to store. We won't store empty queries.
      */