Bug 1272599 part.1 Rename KeyboardEvent.key value, "MozPhoneCall" to "Call" r?smaug
Android's KEYCODE_CALL was temporarily named as "MozPhoneCall" since proper key name was not defined in the spec. However, now, it's defined as "Call" in the latest spec. Therefore, we should rename this key name.
Note that this isn't available on Android because the key event is never fired on applications. However, this key may be useful on B2G. Although, the key is not used by current Gaia.
MozReview-Commit-ID: GF4STYrGMig
--- a/dom/events/KeyNameList.h
+++ b/dom/events/KeyNameList.h
@@ -26,17 +26,16 @@
DEFINE_KEYNAME_WITH_SAME_NAME(Unidentified)
/******************************************************************************
* Our Internal Key Values (must have "Moz" prefix)
*****************************************************************************/
DEFINE_KEYNAME_INTERNAL(PrintableKey, "MozPrintableKey")
DEFINE_KEYNAME_INTERNAL(HomeScreen, "MozHomeScreen")
DEFINE_KEYNAME_INTERNAL(CameraFocusAdjust, "MozCameraFocusAdjust")
-DEFINE_KEYNAME_INTERNAL(PhoneCall, "MozPhoneCall")
DEFINE_KEYNAME_INTERNAL(SoftLeft, "MozSoftLeft")
DEFINE_KEYNAME_INTERNAL(SoftRight, "MozSoftRight")
/******************************************************************************
* Modifier Keys
*****************************************************************************/
DEFINE_KEYNAME_WITH_SAME_NAME(Alt)
DEFINE_KEYNAME_WITH_SAME_NAME(AltGraph)
--- a/widget/NativeKeyToDOMKeyName.h
+++ b/widget/NativeKeyToDOMKeyName.h
@@ -1220,18 +1220,18 @@ KEY_MAP_ANDROID (BrowserSearch, AKEYCODE
KEY_MAP_WIN (BrowserStop, VK_BROWSER_STOP)
KEY_MAP_WIN_CMD (BrowserStop, APPCOMMAND_BROWSER_STOP)
KEY_MAP_GTK (BrowserStop, GDK_Stop)
KEY_MAP_QT (BrowserStop, Qt::Key_Stop)
/******************************************************************************
* Mobile Phone Keys
******************************************************************************/
-// PhoneCall (should be renamed to Call)
-KEY_MAP_ANDROID (PhoneCall, AKEYCODE_CALL)
+// Call
+KEY_MAP_ANDROID (Call, AKEYCODE_CALL)
// Camera
KEY_MAP_QT (Camera, Qt::Key_Camera)
KEY_MAP_ANDROID (Camera, AKEYCODE_CAMERA)
// CameraFocusAdjust (should be renamed to CameraFocus)
KEY_MAP_QT (CameraFocusAdjust, Qt::Key_CameraFocus)
KEY_MAP_ANDROID (CameraFocusAdjust, AKEYCODE_FOCUS)
