Bug 1260299 - Remove references to unsupported Visual Studio versions; r?chmanchester draft
authorGregory Szorc <gps@mozilla.com>
Thu, 19 May 2016 19:59:11 -0700
changeset 369050 97b99f8c1d0748a610487544fc917b5ff7ad0c6b
parent 369022 c67dc1f9fab86d4f2cf3224307809c44fe3ce820
child 369051 eb47ee77793bf0bba923b24cbc6a6150d4c57c63
push id18715
push userbmo:gps@mozilla.com
push dateFri, 20 May 2016 04:59:11 +0000
reviewerschmanchester
bugs1260299
milestone49.0a1
Bug 1260299 - Remove references to unsupported Visual Studio versions; r?chmanchester We only support building with VS2013 and VS2015. Remove references to older versions in the Visual Studio build backend. MozReview-Commit-ID: 6QTSylqLwLF
python/mozbuild/mozbuild/backend/visualstudio.py
--- a/python/mozbuild/mozbuild/backend/visualstudio.py
+++ b/python/mozbuild/mozbuild/backend/visualstudio.py
@@ -32,49 +32,24 @@ from ..frontend.data import (
 from mozbuild.base import ExecutionSummary
 
 
 MSBUILD_NAMESPACE = 'http://schemas.microsoft.com/developer/msbuild/2003'
 
 def get_id(name):
     return str(uuid.uuid5(uuid.NAMESPACE_URL, name)).upper()
 
-# TODO validate mappings are correct. only 2010 confirmed so far
 def visual_studio_product_to_internal_version(version, solution=False):
-    if solution:
-        if version == '2010':
-            return '11.00'
-        elif version == '2011':
-            return '12.00'
-        elif version == '2012':
-            return '12.00'
-        elif version == '2013':
-            return '12.00'
-        else:
-            raise Exception('Unknown version seen: %s' % version)
+    if version == '2013':
+        return '12.00'
     else:
-        if version == '2010':
-            return '10.00'
-        elif version == '2011':
-            return '11.00'
-        elif version == '2012':
-            return '12.00'
-        elif version == '2013':
-            return '12.00'
-        else:
-            raise Exception('Unknown version seen: %s' % version)
+        raise Exception('Unknown version seen: %s' % version)
 
 def visual_studio_product_to_platform_toolset_version(version):
-    if version == '2010':
-        return 'v100'
-    elif version == '2011':
-        return 'v110'
-    elif version == '2012':
-        return 'v120'
-    elif version == '2013':
+    if version == '2013':
         return 'v120'
     else:
         raise Exception('Unknown version seen: %s' % version)
 
 class VisualStudioBackend(CommonBackend):
     """Generate Visual Studio project files.
 
     This backend is used to produce Visual Studio projects and a solution