Bug 754623 - Get page title from tab label; r=mak
MozReview-Commit-ID: BOXUKUcA0fZ
--- a/browser/base/content/browser-places.js
+++ b/browser/base/content/browser-places.js
@@ -549,20 +549,21 @@ var PlacesCommandHook = {
*/
get uniqueCurrentPages() {
let uniquePages = {};
let URIs = [];
gBrowser.visibleTabs.forEach(tab => {
let browser = tab.linkedBrowser;
let uri = browser.currentURI;
+ let title = browser.contentTitle || tab.label;
let spec = uri.spec;
if (!tab.pinned && !(spec in uniquePages)) {
uniquePages[spec] = null;
- URIs.push({ uri, title: browser.contentTitle });
+ URIs.push({ uri, title });
}
});
return URIs;
},
/**
* Adds a folder with bookmarks to all of the currently open tabs in this
* window.
--- a/browser/components/places/tests/browser/browser_bookmark_all_tabs.js
+++ b/browser/components/places/tests/browser/browser_bookmark_all_tabs.js
@@ -23,15 +23,15 @@ add_task(function* () {
Assert.deepEqual(URIs.map(URI => URI.uri.spec), [
"about:blank",
BASE_URL + "bookmark_dummy_1.html",
BASE_URL + "bookmark_dummy_2.html"
], "Correct URIs are returned");
Assert.deepEqual(URIs.map(URI => URI.title), [
- "", "Bookmark Dummy 1", "Bookmark Dummy 2"
+ "New Tab", "Bookmark Dummy 1", "Bookmark Dummy 2"
], "Correct titles are returned");
registerCleanupFunction(function* () {
yield Promise.all(tabs.map(BrowserTestUtils.removeTab));
});
});