Bug 1273076 - Show more details in about:debugging#invalid-hash r?jdescottes
MozReview-Commit-ID: EbQvxXBixRe
--- a/devtools/client/aboutdebugging/aboutdebugging.css
+++ b/devtools/client/aboutdebugging/aboutdebugging.css
@@ -131,15 +131,20 @@ button {
flex: 1;
}
.addons-debugging-label {
display: inline-block;
margin: 0 5px 5px 0;
}
-.page-not-found {
+.error-page {
display: flex;
justify-content: center;
align-items: center;
+ flex-direction: column;
width: 100%;
height: 100%;
}
+
+.error-page .error-page-details {
+ color: gray;
+}
--- a/devtools/client/aboutdebugging/components/aboutdebugging.js
+++ b/devtools/client/aboutdebugging/components/aboutdebugging.js
@@ -81,20 +81,22 @@ module.exports = createClass({
let selectPanel = this.selectPanel;
let selectedPanel = panels.find(p => p.id == selectedPanelId);
let panel;
if (selectedPanel) {
panel = selectedPanel.component({ client, id: selectedPanel.id });
} else {
panel = (
- dom.div({ className: "page-not-found" },
+ dom.div({ className: "error-page" },
dom.h1({ className: "header-name" },
Strings.GetStringFromName("pageNotFound")
- )
+ ),
+ dom.h4({ className: "error-page-details" },
+ Strings.formatStringFromName("doesNotExist", [selectedPanelId], 1))
)
);
}
return dom.div({ className: "app" },
PanelMenu({ panels, selectedPanelId, selectPanel }),
dom.div({ className: "main-content" }, panel)
);
--- a/devtools/client/locales/en-US/aboutdebugging.properties
+++ b/devtools/client/locales/en-US/aboutdebugging.properties
@@ -21,10 +21,11 @@ reload = Reload
workers = Workers
serviceWorkers = Service Workers
sharedWorkers = Shared Workers
otherWorkers = Other Workers
tabs = Tabs
pageNotFound = Page not found
+doesNotExist = #%S does not exist!
nothing = Nothing yet.