Bug 1274051 - Only log telemetry in release builds. r=grisha draft
authorMichael Comella <michael.l.comella@gmail.com>
Wed, 18 May 2016 14:42:46 -0700
changeset 368494 715aeb7ed196a9cf11263f53e5676b46ff87b507
parent 367617 a7e57536b61c186973b8ef1a5efccf630e60d068
child 521297 f476f3a298374d9f9a17ed9158a251a63ad0b81d
push id18560
push usermichael.l.comella@gmail.com
push dateWed, 18 May 2016 22:45:07 +0000
reviewersgrisha
bugs1274051
milestone49.0a1
Bug 1274051 - Only log telemetry in release builds. r=grisha MozReview-Commit-ID: LXTWSIrSvob
mobile/android/base/java/org/mozilla/gecko/Telemetry.java
--- a/mobile/android/base/java/org/mozilla/gecko/Telemetry.java
+++ b/mobile/android/base/java/org/mozilla/gecko/Telemetry.java
@@ -164,21 +164,21 @@ public class Telemetry {
      * @param method A non-null method (if null is desired, consider using Method.NONE)
      */
     private static void sendUIEvent(final String eventName, final Method method,
             final long timestamp, final String extras) {
         if (method == null) {
             throw new IllegalArgumentException("Expected non-null method - use Method.NONE?");
         }
 
-        String logString = "SendUIEvent: event = " + eventName + " method = " + method + " timestamp = " + timestamp;
-        if (!AppConstants.MOZILLA_OFFICIAL) {
-            logString += " extras = " + extras;
+        if (!AppConstants.RELEASE_BUILD) {
+            final String logString = "SendUIEvent: event = " + eventName + " method = " + method + " timestamp = " +
+                    timestamp + " extras = " + extras;
+            Log.d(LOGTAG, logString);
         }
-        Log.d(LOGTAG, logString);
         final GeckoEvent geckoEvent = GeckoEvent.createTelemetryUIEvent(
                 eventName, method.toString(), timestamp, extras);
         GeckoAppShell.sendEventToGecko(geckoEvent);
     }
 
     public static void sendUIEvent(final Event event, final Method method, final long timestamp,
             final String extras) {
         sendUIEvent(event.toString(), method, timestamp, extras);