Bug 1240913 - Catch errors on RDM open / close. r=ochameau draft
authorJ. Ryan Stinnett <jryans@gmail.com>
Tue, 19 Apr 2016 15:58:44 -0500
changeset 368078 f1a46caa101f1120f7cb2657e1e3c126bee68aca
parent 368077 59d131412f855525aff3e66b38a251d5c4feb3c0
child 368079 db3dc72f59c5db7f4a11e49e92b6185140fc8525
push id18425
push userbmo:jryans@gmail.com
push dateWed, 18 May 2016 01:26:45 +0000
reviewersochameau
bugs1240913
milestone49.0a1
Bug 1240913 - Catch errors on RDM open / close. r=ochameau MozReview-Commit-ID: 8WB989Fy1Ce
devtools/client/responsive.html/manager.js
--- a/devtools/client/responsive.html/manager.js
+++ b/devtools/client/responsive.html/manager.js
@@ -37,17 +37,19 @@ const ResponsiveUIManager = exports.Resp
    *        The browser tab.
    * @return Promise
    *         Resolved when the toggling has completed.  If the UI has opened,
    *         it is resolved to the ResponsiveUI instance for this tab.  If the
    *         the UI has closed, there is no resolution value.
    */
   toggle(window, tab) {
     let action = this.isActiveForTab(tab) ? "close" : "open";
-    return this[action + "IfNeeded"](window, tab);
+    let completed = this[action + "IfNeeded"](window, tab);
+    completed.catch(console.error);
+    return completed;
   },
 
   /**
    * Opens the responsive UI, if not already open.
    *
    * @param window
    *        The main browser chrome window.
    * @param tab
@@ -91,17 +93,16 @@ const ResponsiveUIManager = exports.Resp
         off(events.close, "data", onClose);
       }
 
       yield ui.destroy();
       this.emit("off", { tab });
 
       yield setMenuCheckFor(tab, window);
     }
-    return promise.resolve();
   }),
 
   /**
    * Returns true if responsive UI is active for a given tab.
    *
    * @param tab
    *        The browser tab.
    * @return boolean