Bug 1273173 - Fix reader button telemetry events. r=mcomella draft
authorMargaret Leibovic <margaret.leibovic@gmail.com>
Mon, 16 May 2016 21:03:15 -0700
changeset 367650 cc7ba90d8c27581e4b1439ad69766a66bda3e806
parent 367649 c5cfd82c36e54ca7e027e6bf82de7fcbc6863e7c
child 521067 b1efe8fa2ccee060ef0f55023a3b4fa467b739d6
push id18305
push usermleibovic@mozilla.com
push dateTue, 17 May 2016 04:03:41 +0000
reviewersmcomella
bugs1273173
milestone49.0a1
Bug 1273173 - Fix reader button telemetry events. r=mcomella MozReview-Commit-ID: ED2MFgQnh0z
mobile/android/chrome/content/Reader.js
--- a/mobile/android/chrome/content/Reader.js
+++ b/mobile/android/chrome/content/Reader.js
@@ -148,19 +148,19 @@ var Reader = {
       }
     }
   },
 
   pageAction: {
     readerModeCallback: function(browser) {
       let url = browser.currentURI.spec;
       if (url.startsWith("about:reader")) {
-        UITelemetry.addEvent("action.1", "button", "reader_exit");
+        UITelemetry.addEvent("action.1", "button", null, "reader_exit");
       } else {
-        UITelemetry.addEvent("action.1", "button", "reader_enter");
+        UITelemetry.addEvent("action.1", "button", null, "reader_enter");
       }
       browser.messageManager.sendAsyncMessage("Reader:ToggleReaderMode");
     },
   },
 
   updatePageAction: function(tab) {
     if (!tab.getActive()) {
       return;
@@ -189,19 +189,19 @@ var Reader = {
       return;
     }
 
     // Only stop a reader session if the foreground viewer is not visible.
     UITelemetry.stopSession("reader.1", "", null);
 
     if (browser.isArticle) {
       showPageAction("drawable://reader", Strings.reader.GetStringFromName("readerView.enter"));
-      UITelemetry.addEvent("show.1", "button", "reader_available");
+      UITelemetry.addEvent("show.1", "button", null, "reader_available");
     } else {
-      UITelemetry.addEvent("show.1", "button", "reader_unavailable");
+      UITelemetry.addEvent("show.1", "button", null, "reader_unavailable");
     }
   },
 
   /**
    * Gets an article for a given URL. This method will download and parse a document
    * if it does not find the article in the cache.
    *
    * @param url The article URL.