Bug 1251362 - Part 1 - Increase SwipeRefreshLayout weight. r=liuche draft
authorJan Henning <jh+bugzilla@buttercookie.de>
Mon, 16 May 2016 17:53:01 +0200
changeset 376069 e5a6c7db8edc513db239949b5aec0c624a0f08b0
parent 376068 f5b23cad16d3cd9b42017e52c159a79adb553bea
child 376070 c8e37ed3db84920d5051352f6123188f8dfdbb37
push id20500
push usermozilla@buttercookie.de
push dateTue, 07 Jun 2016 11:41:20 +0000
reviewersliuche
bugs1251362, 1267884
milestone50.0a1
Bug 1251362 - Part 1 - Increase SwipeRefreshLayout weight. r=liuche Otherwise, depending on the device's display dimensions, a second smart folder would be overlapped by the empty view message that is displayed when no history is present for the history panel to display. Once we've updated to a newer version of the support library (see bug 1267884), we should revisit this and see if using "wrap_content" is working properly instead. MozReview-Commit-ID: 1xBCeiST9n4
mobile/android/base/resources/layout/home_combined_history_panel.xml
--- a/mobile/android/base/resources/layout/home_combined_history_panel.xml
+++ b/mobile/android/base/resources/layout/home_combined_history_panel.xml
@@ -7,17 +7,17 @@
               android:layout_width="match_parent"
               android:layout_height="match_parent"
               android:orientation="vertical">
 
     <android.support.v4.widget.SwipeRefreshLayout
             android:id="@+id/refresh_layout"
             android:layout_width="match_parent"
             android:layout_height="0dp"
-            android:layout_weight="1">
+            android:layout_weight="1.2">
 
         <org.mozilla.gecko.home.CombinedHistoryRecyclerView
                 android:id="@+id/combined_recycler_view"
                 android:layout_width="match_parent"
                 android:layout_height="match_parent"
                 android:scrollbars="vertical"/>
 
     </android.support.v4.widget.SwipeRefreshLayout>