Bug 1272391 - Send Action instead of Cancel from SimpleHelperUI button r?sebastian draft
authorAndrzej Hunt <ahunt@mozilla.com>
Thu, 12 May 2016 10:56:50 -0700
changeset 366384 d9bd5fd3bca56bd2973bb04b618b7d75685c3932
parent 364905 6ec6d9e1f660dd473ce69648fe1863792e4e740c
child 520767 313b0d1f9f7bc42ec837b1debfcf3947825c2280
push id17974
push userahunt@mozilla.com
push dateThu, 12 May 2016 17:57:20 +0000
reviewerssebastian
bugs1272391
milestone49.0a1
Bug 1272391 - Send Action instead of Cancel from SimpleHelperUI button r?sebastian I didn't pay attention while copying telemetry events. We send cancel when dismissing the prompt, action when the user selects the suggested prompt action. MozReview-Commit-ID: IAOMRRemCiz
mobile/android/base/java/org/mozilla/gecko/promotion/SimpleHelperUI.java
--- a/mobile/android/base/java/org/mozilla/gecko/promotion/SimpleHelperUI.java
+++ b/mobile/android/base/java/org/mozilla/gecko/promotion/SimpleHelperUI.java
@@ -111,17 +111,17 @@ public class SimpleHelperUI extends Loca
 
         final Button button = ((Button) findViewById(R.id.button));
         button.setText(i.getIntExtra(EXTRA_BUTTON, 0));
         button.setOnClickListener(new View.OnClickListener() {
             @Override
             public void onClick(View v) {
                 slideOut();
 
-                Telemetry.sendUIEvent(TelemetryContract.Event.CANCEL, TelemetryContract.Method.BUTTON, mTelemetryExtra);
+                Telemetry.sendUIEvent(TelemetryContract.Event.ACTION, TelemetryContract.Method.BUTTON, mTelemetryExtra);
 
                 setResult(i.getIntExtra(EXTRA_RESULTCODE_POSITIVE, -1));
             }
         });
     }
 
     private void slideIn() {
         containerView.setTranslationY(500);