Bug 1271797 - Remove hack to prevent color override in long-press back history menu. r=liuche draft
authorMichael Comella <michael.l.comella@gmail.com>
Tue, 10 May 2016 14:54:15 -0700
changeset 365487 7e1492b57d11cd8e9dbfb8766b1e443d424249c2
parent 365473 6f344122dda94481acb3996694b89afdafdff95f
child 365488 bd88dbbf79fb9ff8ce84e52ee05b5c1622349357
push id17759
push usermichael.l.comella@gmail.com
push dateTue, 10 May 2016 22:26:38 +0000
reviewersliuche
bugs1271797
milestone49.0a1
Bug 1271797 - Remove hack to prevent color override in long-press back history menu. r=liuche MozReview-Commit-ID: 8pbP5R0XNt1
mobile/android/base/resources/layout/tab_history_item_row.xml
--- a/mobile/android/base/resources/layout/tab_history_item_row.xml
+++ b/mobile/android/base/resources/layout/tab_history_item_row.xml
@@ -35,24 +35,21 @@
         <ImageView android:id="@+id/tab_history_timeline_bottom"
                    android:layout_width="@dimen/tab_history_timeline_width"
                    android:layout_height="@dimen/tab_history_timeline_height"
                    android:layout_gravity="center_horizontal"
                    android:background="@color/tab_history_timeline_separator" />
 
     </LinearLayout>
 
-    <!-- HACK: Widget.TwoLinePageRow overrides the background attr but really shouldn't
-         (bug 1271797). So we override the override and set the background equal to null. -->
     <org.mozilla.gecko.widget.FadedSingleColorTextView
             android:id="@+id/tab_history_title"
             style="@style/Widget.TwoLinePageRow.Title"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:layout_gravity="center_vertical"
-            android:background="@null"
             android:paddingRight="@dimen/tab_history_title_margin_right"
             android:text="@+id/tab_history_title"
             android:textSize="@dimen/tab_history_title_text_size"
             android:textColor="@color/text_and_tabs_tray_grey"
             gecko:fadeWidth="@dimen/tab_history_title_fading_width"/>
 
 </LinearLayout>