Bug 1268603 - Set history background color to @null. r=ahunt draft
authorMichael Comella <michael.l.comella@gmail.com>
Tue, 10 May 2016 14:19:02 -0700
changeset 365472 a64c5d134d0f2d4bc46ede356a5e8517654e9c62
parent 365338 2f9351bae69d056e4615d21dda6bf42fec5d16b7
child 365473 6f344122dda94481acb3996694b89afdafdff95f
child 365970 b9a836ec3ca4a5ddbaf741ad7b3f8a6a6f8cc8bd
push id17752
push usermichael.l.comella@gmail.com
push dateTue, 10 May 2016 21:40:44 +0000
reviewersahunt
bugs1268603
milestone49.0a1
Bug 1268603 - Set history background color to @null. r=ahunt See added comment (and bug it references) for details. MozReview-Commit-ID: CqS5Oy7MPln
mobile/android/base/resources/layout/tab_history_item_row.xml
--- a/mobile/android/base/resources/layout/tab_history_item_row.xml
+++ b/mobile/android/base/resources/layout/tab_history_item_row.xml
@@ -35,21 +35,24 @@
         <ImageView android:id="@+id/tab_history_timeline_bottom"
                    android:layout_width="@dimen/tab_history_timeline_width"
                    android:layout_height="@dimen/tab_history_timeline_height"
                    android:layout_gravity="center_horizontal"
                    android:background="@color/tab_history_timeline_separator" />
 
     </LinearLayout>
 
+    <!-- HACK: Widget.TwoLinePageRow overrides the background attr but really shouldn't
+         (bug 1271797). So we override the override and set the background equal to null. -->
     <org.mozilla.gecko.widget.FadedSingleColorTextView
             android:id="@+id/tab_history_title"
             style="@style/Widget.TwoLinePageRow.Title"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:layout_gravity="center_vertical"
+            android:background="@null"
             android:paddingRight="@dimen/tab_history_title_margin_right"
             android:text="@+id/tab_history_title"
             android:textSize="@dimen/tab_history_title_text_size"
             android:textColor="@color/text_and_tabs_tray_grey"
             gecko:fadeWidth="@dimen/tab_history_title_fading_width"/>
 
 </LinearLayout>