Bug 1270496 - tracking protection switch on about:privatebrowsing should also affect the actual setting when using <space> to toggle it, r?jaws draft
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Thu, 05 May 2016 16:28:28 +0100
changeset 363822 3bb44ea5ea3edfdbbab57b4b64dee6b7a221dc91
parent 363763 b386e97721cfad7464829c88a1a0b8c42e75315c
child 520138 92b0c2dd3406542561e10d84b7ea8facd4164533
push id17309
push usergijskruitbosch@gmail.com
push dateThu, 05 May 2016 16:29:34 +0000
reviewersjaws
bugs1270496
milestone49.0a1
Bug 1270496 - tracking protection switch on about:privatebrowsing should also affect the actual setting when using <space> to toggle it, r?jaws MozReview-Commit-ID: 51bf9AT9eh9
browser/components/privatebrowsing/content/aboutPrivateBrowsing.js
--- a/browser/components/privatebrowsing/content/aboutPrivateBrowsing.js
+++ b/browser/components/privatebrowsing/content/aboutPrivateBrowsing.js
@@ -51,24 +51,23 @@ document.addEventListener("DOMContentLoa
            .setAttribute("href", FAVICON_QUESTION);
    document.getElementById("startPrivateBrowsing")
            .addEventListener("command", openPrivateWindow);
    return;
  }
 
  let tpToggle = document.getElementById("tpToggle");
  document.getElementById("tpButton").addEventListener('click', () => {
-   tpToggle.checked = !tpToggle.checked;
+   tpToggle.click();
  });
 
  document.title = stringBundle.GetStringFromName("title.head");
  document.getElementById("favicon")
          .setAttribute("href", FAVICON_PRIVACY);
- document.getElementById("tpButton")
-         .addEventListener("click", toggleTrackingProtection);
+ tpToggle.addEventListener("change", toggleTrackingProtection);
  document.getElementById("startTour")
          .addEventListener("click", dontShowIntroPanelAgain);
 
  let formatURLPref = Cc["@mozilla.org/toolkit/URLFormatterService;1"]
                        .getService(Ci.nsIURLFormatter).formatURLPref;
  document.getElementById("startTour").setAttribute("href",
                     formatURLPref("privacy.trackingprotection.introURL"));
  document.getElementById("learnMore").setAttribute("href",