hgext: Update reference to docs on MozReview credentials (
bug 1253109); r?gps
MozReview-Commit-ID: KUaBVGRaguo
--- a/hgext/reviewboard/hgrb/proto.py
+++ b/hgext/reviewboard/hgrb/proto.py
@@ -18,17 +18,17 @@ from mercurial import (
)
from mozautomation import commitparser
from hgrb.util import ReviewID
API_KEY_NEEDED = (
'Bugzilla API keys are now used by MozReview; '
- 'see https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#bugzilla-credentials '
+ 'see https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#obtaining-accounts-credentials-and-privileges '
'for instructions on how to configure your client')
class AuthorizationError(Exception):
"""Represents an error authenticating or authorizing to Bugzilla."""
def __init__(self, e, username=None, apikey=None, **kwargs):
self.e = e
@@ -200,17 +200,17 @@ def _processpushreview(repo, req, ldap_u
trust the passed LDAP username has been authenticated to belong to the
MozReview account.
"""
bzusername = req.get('bzusername')
bzapikey = req.get('bzapikey')
if not bzusername or not bzapikey:
return errorresponse('Bugzilla API keys not configured; see '
- 'https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#bugzilla-credentials '
+ 'https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#obtaining-accounts-credentials-and-privileges '
'for instructions on how to configure your client')
identifier = req['identifier']
nodes = []
precursors = {}
for cset in req['changesets']:
node = cset['node']
nodes.append(node)
--- a/hgext/reviewboard/tests/test-auth.t
+++ b/hgext/reviewboard/tests/test-auth.t
@@ -22,52 +22,52 @@ Pushing with a password results in serve
saved backup bundle to $TESTTMP/client/.hg/strip-backup/737709d9e5f4*-addcommitid.hg (glob)
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files
remote: recorded push in pushlog
submitting 1 changesets for review
- abort: Bugzilla API keys not configured; see https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#bugzilla-credentials for instructions on how to configure your client
+ abort: Bugzilla API keys not configured; see https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#obtaining-accounts-credentials-and-privileges for instructions on how to configure your client
[255]
Pushing with a cookie results in server rejection
$ hg --config bugzilla.userid=baduserid --config bugzilla.cookie=irrelevant --config bugzilla.apikey= push
pushing to ssh://$DOCKER_HOSTNAME:$HGPORT6/test-repo
searching for changes
no changes found
submitting 1 changesets for review
- abort: Bugzilla API keys not configured; see https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#bugzilla-credentials for instructions on how to configure your client
+ abort: Bugzilla API keys not configured; see https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#obtaining-accounts-credentials-and-privileges for instructions on how to configure your client
[255]
Pushing with unknown username with API key results in sane failure
$ hg --config bugzilla.username=unknown --config bugzilla.apikey=irrelevant push
pushing to ssh://$DOCKER_HOSTNAME:$HGPORT6/test-repo
searching for changes
no changes found
submitting 1 changesets for review
- abort: Bugzilla API keys are now used by MozReview; see https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#bugzilla-credentials for instructions on how to configure your client
+ abort: Bugzilla API keys are now used by MozReview; see https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#obtaining-accounts-credentials-and-privileges for instructions on how to configure your client
[255]
Pushing with invalid API key results in sane failure
We need to test with a new user here because the default user is already
created in Review Board.
$ adminbugzilla create-user apikey1@example.com api1password 'API Key1'
created user 6
$ hg --config bugzilla.username=apikey1@example.com --config bugzilla.apikey=badkey push
pushing to ssh://$DOCKER_HOSTNAME:$HGPORT6/test-repo
searching for changes
no changes found
submitting 1 changesets for review
- abort: Bugzilla API keys are now used by MozReview; see https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#bugzilla-credentials for instructions on how to configure your client
+ abort: Bugzilla API keys are now used by MozReview; see https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#obtaining-accounts-credentials-and-privileges for instructions on how to configure your client
[255]
User must log in via web interface before pushing with an API key
$ apikey=`mozreview create-api-key apikey1@example.com`
$ hg --config bugzilla.username=apikey1@example.com --config bugzilla.apikey=${apikey} push
pushing to ssh://$DOCKER_HOSTNAME:$HGPORT6/test-repo
searching for changes