Bug 1269888 - Update color for pressed "Hidden devices" state. draft
authorChenxia Liu <liuche@mozilla.com>
Tue, 03 May 2016 18:39:00 -0700
changeset 363153 e92ea536d3e880c39a665eafa651e27bc5fa755d
parent 363129 932e2fda5e33bd2d80ac53df43ee59880780ad7c
child 519954 012b5987bd65d6ba2529a5fe074c86fa5ddac523
push id17115
push usercliu@mozilla.com
push dateWed, 04 May 2016 01:39:49 +0000
bugs1269888
milestone49.0a1
Bug 1269888 - Update color for pressed "Hidden devices" state. MozReview-Commit-ID: 5uJt73es5ZU
mobile/android/base/resources/layout/home_remote_tabs_hidden_devices.xml
mobile/android/base/resources/values/styles.xml
--- a/mobile/android/base/resources/layout/home_remote_tabs_hidden_devices.xml
+++ b/mobile/android/base/resources/layout/home_remote_tabs_hidden_devices.xml
@@ -3,15 +3,14 @@
    This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/.
 -->
 
 <TextView xmlns:android="http://schemas.android.com/apk/res/android"
     android:id="@+id/hidden_devices"
     style="@style/Widget.Home.ActionItem"
-    android:background="@drawable/action_bar_button"
     android:layout_width="match_parent"
     android:layout_height="@dimen/home_remote_tabs_hidden_footer_height"
     android:gravity="center"
     android:maxLength="1024"
     android:textSize="12dp"
     android:textColor="@color/disabled_grey" />
--- a/mobile/android/base/resources/values/styles.xml
+++ b/mobile/android/base/resources/values/styles.xml
@@ -249,16 +249,19 @@
         <item name="android:paddingRight">10dip</item>
     </style>
 
     <style name="Widget.Home.ActionItem">
         <item name="android:layout_width">fill_parent</item>
         <item name="android:layout_height">40dip</item>
         <item name="android:textColor">#000000</item>
         <item name="android:gravity">center</item>
+        <item name="android:drawSelectorOnTop">true</item>
+        <item name="android:listSelector">@drawable/action_bar_button</item>
+        <item name="android:cacheColorHint">@android:color/transparent</item>
     </style>
 
     <style name="Widget.Firstrun.Button" parent="Widget.BaseButton">
         <item name="android:layout_width">@dimen/firstrun_content_width</item>
         <item name="android:layout_height">60dp</item>
         <item name="android:textColor">@color/android:white</item>
         <item name="android:background">@color/action_orange</item>
         <item name="android:textSize">18sp</item>
@@ -531,21 +534,16 @@
     <style name="Widget.RemoteTabsClientView" parent="Widget.TwoLinePageRow">
         <item name="android:background">@color/about_page_header_grey</item>
     </style>
 
     <style name="Widget.RemoteTabsListView" parent="Widget.HomeListView">
         <item name="android:childDivider">@color/toolbar_divider_grey</item>
     </style>
 
-    <style name="Widget.HistoryListView" parent="Widget.HomeListView">
-        <item name="android:childDivider">@color/toolbar_divider_grey</item>
-        <item name="android:drawSelectorOnTop">true</item>
-    </style>
-
     <!-- TabsLayout Row -->
     <style name="TabLayoutItemTextAppearance">
         <item name="android:textColor">#FFFFFFFF</item>
         <item name="android:singleLine">true</item>
         <item name="android:ellipsize">middle</item>
     </style>
 
     <!-- TabsLayout RemoteTabs Row Url -->