Bug 1269774 - Fix padding for context menu icons r=sebastian draft
authorAndrzej Hunt <andrzej@ahunt.org>
Tue, 03 May 2016 10:09:28 -0700
changeset 365049 f36268a3980890f7d7695e3a5161535e20c6cf57
parent 365048 2746ba7569387c766c120909d77916ea5e2bd6ae
child 365050 24fd09f07ca5477dc2938ee377f1a46a8d5c608e
child 365064 0c027526b324d4de9c748a616ca3d760d1d78e77
push id17618
push userbmo:ahunt@mozilla.com
push dateMon, 09 May 2016 22:37:41 +0000
reviewerssebastian
bugs1269774
milestone49.0a1
Bug 1269774 - Fix padding for context menu icons r=sebastian The icons in the first row require more padding. In the second row the share icons should have more padding, however all other icons should remain the same size - it's simplest to adapt the padding by using separate styles for each type of icon. MozReview-Commit-ID: 54NzYtUpzuV
mobile/android/base/java/org/mozilla/gecko/menu/MenuItemSwitcherLayout.java
mobile/android/base/resources/drawable-hdpi/ic_menu_share.png
mobile/android/base/resources/drawable-hdpi/ic_menu_share_icon.png
mobile/android/base/resources/drawable-xhdpi/ic_menu_share.png
mobile/android/base/resources/drawable-xhdpi/ic_menu_share_icon.png
mobile/android/base/resources/drawable-xxhdpi/ic_menu_share.png
mobile/android/base/resources/drawable-xxhdpi/ic_menu_share_icon.png
mobile/android/base/resources/drawable/ic_menu_share.xml
mobile/android/base/resources/values/attrs.xml
mobile/android/base/resources/values/styles.xml
mobile/android/base/resources/values/themes.xml
--- a/mobile/android/base/java/org/mozilla/gecko/menu/MenuItemSwitcherLayout.java
+++ b/mobile/android/base/java/org/mozilla/gecko/menu/MenuItemSwitcherLayout.java
@@ -139,17 +139,17 @@ public class MenuItemSwitcherLayout exte
     public void addActionButton(Drawable drawable, CharSequence label) {
         // If this is the first icon, retain the text.
         // If not, make the menu item an icon.
         final int count = mActionButtons.size();
         mMenuItem.setVisibility(View.GONE);
         mMenuButton.setVisibility(View.VISIBLE);
 
         if (drawable != null) {
-            ImageButton button = new ImageButton(getContext(), null, R.attr.menuItemShareActionButtonStyle);
+            ImageButton button = new ImageButton(getContext(), null, R.attr.menuItemSecondaryActionBarStyle);
             button.setImageDrawable(drawable);
             button.setContentDescription(label);
             button.setOnClickListener(this);
             button.setTag(count);
 
             final int height = (int) (getResources().getDimension(R.dimen.menu_item_row_height));
             LinearLayout.LayoutParams params = new LinearLayout.LayoutParams(0, height);
             params.weight = 1.0f;
rename from mobile/android/base/resources/drawable-hdpi/ic_menu_share.png
rename to mobile/android/base/resources/drawable-hdpi/ic_menu_share_icon.png
rename from mobile/android/base/resources/drawable-xhdpi/ic_menu_share.png
rename to mobile/android/base/resources/drawable-xhdpi/ic_menu_share_icon.png
rename from mobile/android/base/resources/drawable-xxhdpi/ic_menu_share.png
rename to mobile/android/base/resources/drawable-xxhdpi/ic_menu_share_icon.png
new file mode 100644
--- /dev/null
+++ b/mobile/android/base/resources/drawable/ic_menu_share.xml
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="utf-8"?>
+<inset xmlns:android="http://schemas.android.com/apk/res/android"
+    android:drawable="@drawable/ic_menu_share_icon"
+    android:insetTop="3dp"
+    android:insetRight="3dp"
+    android:insetBottom="3dp"
+    android:insetLeft="3dp"/>
--- a/mobile/android/base/resources/values/attrs.xml
+++ b/mobile/android/base/resources/values/attrs.xml
@@ -20,19 +20,16 @@
         <attr name="menuItemSwitcherLayoutStyle" format="reference"/>
 
         <!-- Style for MenuItemDefault -->
         <attr name="menuItemDefaultStyle" format="reference"/>
 
         <!-- Style for MenuItemActionBar when shown in SecondaryActionBar -->
         <attr name="menuItemSecondaryActionBarStyle" format="reference"/>
 
-        <!-- Style for MenuItemSwitcherLayout's ShareActionButton -->
-        <attr name="menuItemShareActionButtonStyle" format="reference"/>
-
         <!-- Default style for the BookmarksListView -->
         <attr name="bookmarksListViewStyle" format="reference" />
 
         <!-- Default style for the TopSitesGridItemView -->
         <attr name="topSitesGridItemViewStyle" format="reference" />
 
         <!-- Styles for dynamic panel grid views -->
         <attr name="panelIconViewStyle" format="reference" />
--- a/mobile/android/base/resources/values/styles.xml
+++ b/mobile/android/base/resources/values/styles.xml
@@ -81,17 +81,17 @@
     </style>
 
     <style name="Widget.GeckoMenuListView" parent="Widget.ListView">
         <item name="android:listSelector">@drawable/menu_item_action_bar_bg</item>
         <item name="android:divider">@color/toolbar_divider_grey</item>
     </style>
 
     <style name="Widget.MenuItemActionBar">
-        <item name="android:padding">8dip</item>
+        <item name="android:padding">10dip</item>
         <item name="android:background">@drawable/menu_item_action_bar_bg</item>
         <item name="android:scaleType">fitCenter</item>
         <item name="drawableTintList">@color/action_bar_menu_item_colors</item>"
     </style>
 
     <style name="Widget.MenuItemSecondaryActionBar">
         <item name="android:padding">8dip</item>
         <item name="android:background">@drawable/menu_item_action_bar_bg</item>
--- a/mobile/android/base/resources/values/themes.xml
+++ b/mobile/android/base/resources/values/themes.xml
@@ -90,17 +90,16 @@
         <item name="android:spinnerStyle">@style/Widget.Spinner</item>
         <item name="android:windowBackground">@android:color/white</item>
         <item name="bookmarksListViewStyle">@style/Widget.BookmarksListView</item>
         <item name="tabGridLayoutViewStyle">@style/Widget.TabsGridLayout</item>
         <item name="geckoMenuListViewStyle">@style/Widget.GeckoMenuListView</item>
         <item name="homeListViewStyle">@style/Widget.HomeListView</item>
         <item name="menuItemActionBarStyle">@style/Widget.MenuItemActionBar</item>
         <item name="menuItemActionModeStyle">@style/GeckoActionBar.Button</item>
-        <item name="menuItemShareActionButtonStyle">@style/Widget.MenuItemSecondaryActionBar</item>
         <item name="topSitesGridItemViewStyle">@style/Widget.TopSitesGridItemView</item>
         <item name="topSitesGridViewStyle">@style/Widget.TopSitesGridView</item>
         <item name="topSitesThumbnailViewStyle">@style/Widget.TopSitesThumbnailView</item>
     </style>
 
     <style name="Gecko.Preferences" parent="GeckoPreferencesBase">
         <!-- This fixed bug 1233412 (Crash in GeckoPrefs due to missing colorAccent in JB) -->
         <item name="colorAccent">@color/action_orange</item>