Bug 1268548 - Add telemetry for when the addon manager upgrade dialog is shown, r?rhelmber draft
authorBenjamin Smedberg <benjamin@smedbergs.us>
Thu, 28 Apr 2016 13:07:42 -0400
changeset 357413 d60a60c33c737b86605d3ccb07343474cfe48a97
parent 356251 8e1a775445fe6a99adb586a6b3006abde516c15e
child 519634 61ebe9adb0d51c0e97fce575f6c0c46d7019fc0c
push id16770
push userbsmedberg@mozilla.com
push dateThu, 28 Apr 2016 17:08:47 +0000
reviewersrhelmber
bugs1268548
milestone48.0a1
Bug 1268548 - Add telemetry for when the addon manager upgrade dialog is shown, r?rhelmber MozReview-Commit-ID: 7dxkY9lIMWc
toolkit/components/telemetry/Histograms.json
toolkit/mozapps/extensions/internal/XPIProvider.jsm
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -22,16 +22,24 @@
   },
   "A11Y_UPDATE_TIME": {
     "expires_in_version": "default",
     "kind": "exponential",
     "high": 10000,
     "n_buckets": 50,
     "description": "time spent updating accessibility (ms)"
   },
+  "ADDON_MANAGER_UPGRADE_UI_SHOWN": {
+    "expires_in_version": "53",
+    "kind": "flag",
+    "description": "Recorded when the addon manager shows the modal upgrade UI. Should only be recorded once per upgrade.",
+    "releaseChannelCollection": "opt-out",
+    "bug_numbers": [1268548],
+    "alert_emails": ["kev@mozilla.com"]
+  },
   "ADDON_SHIM_USAGE": {
     "expires_in_version": "never",
     "kind": "enumerated",
     "n_values": 15,
     "keyed": true,
     "description": "Reasons why add-on shims were used, keyed by add-on ID."
   },
   "BROWSER_SHIM_USAGE_BLOCKED": {
--- a/toolkit/mozapps/extensions/internal/XPIProvider.jsm
+++ b/toolkit/mozapps/extensions/internal/XPIProvider.jsm
@@ -2928,16 +2928,18 @@ this.XPIProvider = {
    * Shows the "Compatibility Updates" UI.
    *
    * @param  aAddonIDs
    *         Array opf addon IDs that were disabled by the application update, and
    *         should therefore be checked for updates.
    */
   showUpgradeUI: function(aAddonIDs) {
     logger.debug("XPI_showUpgradeUI: " + aAddonIDs.toSource());
+    Services.telemetry.getHistogramById("ADDON_MANAGER_UPGRADE_UI_SHOWN").add(1);
+
     // Flip a flag to indicate that we interrupted startup with an interactive prompt
     Services.startup.interrupted = true;
 
     var variant = Cc["@mozilla.org/variant;1"].
                   createInstance(Ci.nsIWritableVariant);
     variant.setFromVariant(aAddonIDs);
 
     // This *must* be modal as it has to block startup.