Bug 1268449 - prevent memory leak in Resolve. r?ekr draft
authorAndi-Bogdan Postelnicu <bogdan.postelnicu@softvision.ro>
Thu, 28 Apr 2016 14:13:55 +0300
changeset 357257 0b8d201d7e8190c6fbbf18f32107253ac651d2e7
parent 356965 86730d0a82093d705e44f33a34973d28b269f1ea
child 363249 b1960b90ff577683e8d8754bd6ba6c9c58c64277
push id16744
push userBogdan.Postelnicu@softvision.ro
push dateThu, 28 Apr 2016 11:14:22 +0000
reviewersekr
bugs1268449
milestone49.0a1
Bug 1268449 - prevent memory leak in Resolve. r?ekr MozReview-Commit-ID: 7K94oXrkhne
media/mtransport/test/ice_unittest.cpp
--- a/media/mtransport/test/ice_unittest.cpp
+++ b/media/mtransport/test/ice_unittest.cpp
@@ -104,23 +104,25 @@ Resolve(const std::string& fqdn, int add
           AF_INET6,
           &reinterpret_cast<struct sockaddr_in6*>(res->ai_addr)->sin6_addr,
           str_addr,
           sizeof(str_addr));
       break;
     default:
       std::cerr << "Got unexpected address family in DNS lookup: "
                 << res->ai_family << std::endl;
+      freeaddrinfo(res);
       return "";
   }
 
   if (!strlen(str_addr)) {
     std::cerr << "inet_ntop failed" << std::endl;
   }
 
+  freeaddrinfo(res);
   return str_addr;
 }
 
 class StunTest : public MtransportTest {
 public:
   StunTest() : MtransportTest() {
     stun_server_hostname_ = kDefaultStunServerHostname;
   }