Bug 1000700 - Part 1: Use white dropmarkers on dark dev edition theme on OSX; r?Gijs draft
authorScott Wu <scottcwwu@gmail.com>
Tue, 26 Apr 2016 15:56:55 +0800
changeset 356319 9dd579ed5af2a85cdc32c57c0a6246c7030a4ce4
parent 355869 4c3b5f9bd44a64ff81a49653881c5415b088a504
child 519384 c5da82f745c68a9a79c96ba5736f0ea9b640d29c
push id16493
push userbmo:scwwu@mozilla.com
push dateTue, 26 Apr 2016 08:00:01 +0000
reviewersGijs
bugs1000700
milestone48.0a1
Bug 1000700 - Part 1: Use white dropmarkers on dark dev edition theme on OSX; r?Gijs MozReview-Commit-ID: HLKGurCkn5T
browser/themes/osx/browser.css
browser/themes/osx/devedition.css
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -295,25 +295,29 @@ toolbarbutton.bookmark-item:not(.subview
   padding: 1px 8px;
   margin: 0 0 1px;
 }
 
 #personal-bookmarks[cui-areatype="toolbar"]:not([overflowedItem=true]) > #bookmarks-toolbar-placeholder {
   -moz-box-orient: horizontal;
 }
 
+.toolbarbutton-1 > .toolbarbutton-menu-dropmarker,
+.toolbarbutton-1 > .toolbarbutton-menubutton-dropmarker,
 .bookmark-item > .toolbarbutton-menu-dropmarker {
   list-style-image: url("chrome://browser/skin/places/folderDropArrow.png");
   -moz-image-region: rect(0, 7px, 5px, 0);
   margin-top: 1px;
   -moz-margin-start: 3px;
   -moz-margin-end: -2px;
 }
 
 @media (min-resolution: 2dppx) {
+  .toolbarbutton-1 > .toolbarbutton-menu-dropmarker,
+  .toolbarbutton-1 > .toolbarbutton-menubutton-dropmarker,
   .bookmark-item > .toolbarbutton-menu-dropmarker {
     list-style-image: url("chrome://browser/skin/places/folderDropArrow@2x.png");
     -moz-image-region: rect(0, 14px, 10px, 0);
   }
 
   .bookmark-item > .toolbarbutton-menu-dropmarker > .dropmarker-icon {
     width: 7px;
   }
@@ -1075,27 +1079,17 @@ toolbar .toolbarbutton-1 > .toolbarbutto
 
   #main-window:not([customizing]) .toolbarbutton-1:-moz-window-inactive[disabled="true"] > .toolbarbutton-icon,
   #main-window:not([customizing]) .toolbarbutton-1:-moz-window-inactive[disabled="true"] > .toolbarbutton-badge-stack > .toolbarbutton-icon,
   #main-window:not([customizing]) .toolbarbutton-1:-moz-window-inactive > .toolbarbutton-menubutton-button[disabled="true"] > .toolbarbutton-icon {
     opacity: .25;
   }
 }
 
-.toolbarbutton-1 > .toolbarbutton-menu-dropmarker,
-.toolbarbutton-1 > .toolbarbutton-menubutton-dropmarker {
-  list-style-image: url(chrome://browser/skin/toolbarbutton-dropmarker.png);
-}
-
 @media (min-resolution: 2dppx) {
-  .toolbarbutton-1 > .toolbarbutton-menu-dropmarker,
-  .toolbarbutton-1 > .toolbarbutton-menubutton-dropmarker {
-    list-style-image: url(chrome://browser/skin/toolbarbutton-dropmarker@2x.png);
-  }
-
   .toolbarbutton-1 > .toolbarbutton-menu-dropmarker > .dropmarker-icon,
   .toolbarbutton-1 > .toolbarbutton-menubutton-dropmarker > .dropmarker-icon {
     width: 7px;
   }
 }
 
 .toolbarbutton-1 > .toolbarbutton-menu-dropmarker {
   -moz-margin-end: 1px;
--- a/browser/themes/osx/devedition.css
+++ b/browser/themes/osx/devedition.css
@@ -110,20 +110,26 @@
 }
 
 :root[devtoolstheme="dark"] .findbar-closebutton:not(:hover),
 /* Tab styling - make sure to use an inverted icon for the selected tab
    (brighttext only covers the unselected tabs) */
 .tab-close-button[visuallyselected=true]:not(:hover) {
   -moz-image-region: rect(0, 64px, 16px, 48px);
 }
+:root[devtoolstheme="dark"] .toolbarbutton-menu-dropmarker:not(:hover) {
+  -moz-image-region: rect(5px, 7px, 10px, 0);
+}
 @media (min-resolution: 2dppx) {
   :root[devtoolstheme="dark"] .findbar-closebutton:not(:hover),
   .tab-close-button[visuallyselected=true]:not(:hover) {
     -moz-image-region: rect(0, 128px, 32px, 96px);
   }
+  :root[devtoolstheme="dark"] .toolbarbutton-menu-dropmarker:not(:hover) {
+    -moz-image-region: rect(10px, 14px, 20px, 0);
+  }
 }
 
 .ac-type-icon {
   /* Left-align the type icon in awesomebar popup results with the icon in the
      urlbar. */
   -moz-margin-start: 14px;
 }