Bug 1267524 Part 11 - Use member initializer list for nsStyleVisibility.
MozReview-Commit-ID: I8YHela8U4Z
--- a/layout/style/nsStyleStruct.cpp
+++ b/layout/style/nsStyleStruct.cpp
@@ -3185,42 +3185,39 @@ nsChangeHint nsStyleDisplay::CalcDiffere
return hint;
}
// --------------------
// nsStyleVisibility
//
nsStyleVisibility::nsStyleVisibility(StyleStructContext aContext)
+ : mDirection(aContext.GetBidi() == IBMBIDI_TEXTDIRECTION_RTL
+ ? NS_STYLE_DIRECTION_RTL
+ : NS_STYLE_DIRECTION_LTR)
+ , mVisible(NS_STYLE_VISIBILITY_VISIBLE)
+ , mImageRendering(NS_STYLE_IMAGE_RENDERING_AUTO)
+ , mWritingMode(NS_STYLE_WRITING_MODE_HORIZONTAL_TB)
+ , mTextOrientation(NS_STYLE_TEXT_ORIENTATION_MIXED)
+ , mColorAdjust(NS_STYLE_COLOR_ADJUST_ECONOMY)
{
MOZ_COUNT_CTOR(nsStyleVisibility);
- uint32_t bidiOptions = aContext.GetBidi();
- if (GET_BIDI_OPTION_DIRECTION(bidiOptions) == IBMBIDI_TEXTDIRECTION_RTL)
- mDirection = NS_STYLE_DIRECTION_RTL;
- else
- mDirection = NS_STYLE_DIRECTION_LTR;
-
- mVisible = NS_STYLE_VISIBILITY_VISIBLE;
- mImageRendering = NS_STYLE_IMAGE_RENDERING_AUTO;
- mWritingMode = NS_STYLE_WRITING_MODE_HORIZONTAL_TB;
- mTextOrientation = NS_STYLE_TEXT_ORIENTATION_MIXED;
- mColorAdjust = NS_STYLE_COLOR_ADJUST_ECONOMY;
}
nsStyleVisibility::nsStyleVisibility(const nsStyleVisibility& aSource)
+ : mImageOrientation(aSource.mImageOrientation)
+ , mDirection(aSource.mDirection)
+ , mVisible(aSource.mVisible)
+ , mImageRendering(aSource.mImageRendering)
+ , mWritingMode(aSource.mWritingMode)
+ , mTextOrientation(aSource.mTextOrientation)
+ , mColorAdjust(aSource.mColorAdjust)
{
MOZ_COUNT_CTOR(nsStyleVisibility);
- mImageOrientation = aSource.mImageOrientation;
- mDirection = aSource.mDirection;
- mVisible = aSource.mVisible;
- mImageRendering = aSource.mImageRendering;
- mWritingMode = aSource.mWritingMode;
- mTextOrientation = aSource.mTextOrientation;
- mColorAdjust = aSource.mColorAdjust;
-}
+}
nsChangeHint nsStyleVisibility::CalcDifference(const nsStyleVisibility& aOther) const
{
nsChangeHint hint = nsChangeHint(0);
if (mDirection != aOther.mDirection || mWritingMode != aOther.mWritingMode) {
// It's important that a change in mWritingMode results in frame
// reconstruction, because it may affect intrinsic size (see