Bug 1267524 Part 1 - Use member initializer list for nsStyleOutline. draft
authorTing-Yu Lin <tlin@mozilla.com>
Mon, 02 May 2016 11:11:45 +0800
changeset 362810 d8f830dab950a84f2dac4c53060c91417d0a9cf8
parent 358327 77cead2cd20300623eea2416bc9bce4d5021df09
child 362811 fb58455e965b01a4f2d2aa95d83c1e83e39576cb
push id17040
push usertlin@mozilla.com
push dateTue, 03 May 2016 09:29:38 +0000
bugs1267524
milestone49.0a1
Bug 1267524 Part 1 - Use member initializer list for nsStyleOutline. mCachedOutlineWidth was not initialized. I set it to 0. MozReview-Commit-ID: fqaoZj1iMm
layout/style/nsStyleStruct.cpp
--- a/layout/style/nsStyleStruct.cpp
+++ b/layout/style/nsStyleStruct.cpp
@@ -561,32 +561,30 @@ nsChangeHint nsStyleBorder::CalcDifferen
   if (mBorder != aOther.mBorder) {
     return nsChangeHint_NeutralChange;
   }
 
   return NS_STYLE_HINT_NONE;
 }
 
 nsStyleOutline::nsStyleOutline(StyleStructContext aContext)
+  : mOutlineWidth(NS_STYLE_BORDER_WIDTH_MEDIUM, eStyleUnit_Enumerated)
+  , mOutlineOffset(0)
+  , mCachedOutlineWidth(0)
+  , mOutlineColor(NS_RGB(0, 0, 0))
+  , mOutlineStyle(NS_STYLE_BORDER_STYLE_NONE)
+  , mTwipsPerPixel(aContext.DevPixelsToAppUnits(1))
 {
   MOZ_COUNT_CTOR(nsStyleOutline);
   // spacing values not inherited
   nsStyleCoord zero(0, nsStyleCoord::CoordConstructor);
   NS_FOR_CSS_HALF_CORNERS(corner) {
     mOutlineRadius.Set(corner, zero);
   }
 
-  mOutlineOffset = 0;
-
-  mOutlineWidth = nsStyleCoord(NS_STYLE_BORDER_WIDTH_MEDIUM, eStyleUnit_Enumerated);
-  mOutlineStyle = NS_STYLE_BORDER_STYLE_NONE;
-  mOutlineColor = NS_RGB(0, 0, 0);
-
-  mTwipsPerPixel = aContext.DevPixelsToAppUnits(1);
-
   SetOutlineInitialColor();
 }
 
 nsStyleOutline::nsStyleOutline(const nsStyleOutline& aSrc)
   : mOutlineRadius(aSrc.mOutlineRadius)
   , mOutlineWidth(aSrc.mOutlineWidth)
   , mOutlineOffset(aSrc.mOutlineOffset)
   , mCachedOutlineWidth(aSrc.mCachedOutlineWidth)