Bug 1267524 Part 1 - Use member initializer list for nsStyleOutline.
mCachedOutlineWidth was not initialized. I set it to 0.
MozReview-Commit-ID: fqaoZj1iMm
--- a/layout/style/nsStyleStruct.cpp
+++ b/layout/style/nsStyleStruct.cpp
@@ -561,32 +561,30 @@ nsChangeHint nsStyleBorder::CalcDifferen
if (mBorder != aOther.mBorder) {
return nsChangeHint_NeutralChange;
}
return NS_STYLE_HINT_NONE;
}
nsStyleOutline::nsStyleOutline(StyleStructContext aContext)
+ : mOutlineWidth(NS_STYLE_BORDER_WIDTH_MEDIUM, eStyleUnit_Enumerated)
+ , mOutlineOffset(0)
+ , mCachedOutlineWidth(0)
+ , mOutlineColor(NS_RGB(0, 0, 0))
+ , mOutlineStyle(NS_STYLE_BORDER_STYLE_NONE)
+ , mTwipsPerPixel(aContext.DevPixelsToAppUnits(1))
{
MOZ_COUNT_CTOR(nsStyleOutline);
// spacing values not inherited
nsStyleCoord zero(0, nsStyleCoord::CoordConstructor);
NS_FOR_CSS_HALF_CORNERS(corner) {
mOutlineRadius.Set(corner, zero);
}
- mOutlineOffset = 0;
-
- mOutlineWidth = nsStyleCoord(NS_STYLE_BORDER_WIDTH_MEDIUM, eStyleUnit_Enumerated);
- mOutlineStyle = NS_STYLE_BORDER_STYLE_NONE;
- mOutlineColor = NS_RGB(0, 0, 0);
-
- mTwipsPerPixel = aContext.DevPixelsToAppUnits(1);
-
SetOutlineInitialColor();
}
nsStyleOutline::nsStyleOutline(const nsStyleOutline& aSrc)
: mOutlineRadius(aSrc.mOutlineRadius)
, mOutlineWidth(aSrc.mOutlineWidth)
, mOutlineOffset(aSrc.mOutlineOffset)
, mCachedOutlineWidth(aSrc.mCachedOutlineWidth)