Bug 1261955 - Remove VIDEO_MSE_BUFFERING_COUNT telemetry probe. r=SingingTree draft
authorRalph Giles <giles@mozilla.com>
Thu, 21 Apr 2016 14:24:20 -0700
changeset 363872 4f9582bfbba41d37000009e4e7c1e02b51c3d9dc
parent 363871 1fdd8d50a38bb5928d37311cc1c16c7ebee9605e
child 363873 b13b1f15195a0a1871a5f61101ddc77e840d9049
push id17329
push userbmo:giles@thaumas.net
push dateThu, 05 May 2016 19:43:28 +0000
reviewersSingingTree
bugs1261955
milestone49.0a1
Bug 1261955 - Remove VIDEO_MSE_BUFFERING_COUNT telemetry probe. r=SingingTree This is no longer necessary. MozReview-Commit-ID: 8017y0v7VEc
dom/html/HTMLMediaElement.cpp
toolkit/components/telemetry/Histograms.json
toolkit/components/telemetry/histogram-whitelists.json
--- a/dom/html/HTMLMediaElement.cpp
+++ b/dom/html/HTMLMediaElement.cpp
@@ -4324,17 +4324,16 @@ nsresult HTMLMediaElement::DispatchAsync
   if (!mMediaSource) {
     return NS_OK;
   }
 
   if ((aName.EqualsLiteral("play") || aName.EqualsLiteral("playing"))) {
     mPlayTime.Start();
   } else if (aName.EqualsLiteral("waiting")) {
     mPlayTime.Pause();
-    Telemetry::Accumulate(Telemetry::VIDEO_MSE_BUFFERING_COUNT, 1);
   } else if (aName.EqualsLiteral("pause")) {
     mPlayTime.Pause();
   }
 
   return NS_OK;
 }
 
 nsresult HTMLMediaElement::DispatchPendingMediaEvents()
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -8950,21 +8950,16 @@
   },
   "VIDEO_MSE_PLAY_TIME_MS" : {
     "expires_in_version": "45",
     "description": "Total time spent playing MSE video",
     "kind": "exponential",
     "high": 7200000,
     "n_buckets": 100
   },
-  "VIDEO_MSE_BUFFERING_COUNT" : {
-    "expires_in_version": "45",
-    "description": "Count of times that MSE video was buffering",
-    "kind": "count"
-  },
   "VIDEO_MSE_UNLOAD_STATE": {
     "expires_in_version": "45",
     "kind": "enumerated",
     "n_values": 5,
     "description": "MSE video state when unloading. ended = 0, paused = 1, stalled = 2, seeking = 3, other = 4"
   },
   "VIDEO_ADOBE_GMP_DISAPPEARED": {
     "alert_emails": ["cpearce@mozilla.com"],
--- a/toolkit/components/telemetry/histogram-whitelists.json
+++ b/toolkit/components/telemetry/histogram-whitelists.json
@@ -1013,17 +1013,16 @@
     "VIDEO_CANPLAYTYPE_H264_CONSTRAINT_SET_FLAG",
     "VIDEO_CANPLAYTYPE_H264_LEVEL",
     "VIDEO_CANPLAYTYPE_H264_PROFILE",
     "VIDEO_DECODED_H264_SPS_CONSTRAINT_SET_FLAG",
     "VIDEO_DECODED_H264_SPS_LEVEL",
     "VIDEO_DECODED_H264_SPS_PROFILE",
     "VIDEO_EME_PLAY_SUCCESS",
     "VIDEO_H264_SPS_MAX_NUM_REF_FRAMES",
-    "VIDEO_MSE_BUFFERING_COUNT",
     "VIDEO_MSE_PLAY_TIME_MS",
     "VIDEO_MSE_UNLOAD_STATE",
     "WEAVE_COMPLETE_SUCCESS_COUNT",
     "WEAVE_CONFIGURED",
     "WEAVE_CONFIGURED_MASTER_PASSWORD",
     "WEAVE_START_COUNT",
     "WEBCRYPTO_ALG",
     "WEBCRYPTO_EXTRACTABLE_ENC",
@@ -2380,17 +2379,16 @@
     "VIDEO_DECODED_H264_SPS_PROFILE",
     "VIDEO_EME_ADOBE_HIDDEN_REASON",
     "VIDEO_EME_ADOBE_INSTALL_FAILED_REASON",
     "VIDEO_EME_ADOBE_UNSUPPORTED_REASON",
     "VIDEO_EME_PLAY_SUCCESS",
     "VIDEO_EME_REQUEST_FAILURE_LATENCY_MS",
     "VIDEO_EME_REQUEST_SUCCESS_LATENCY_MS",
     "VIDEO_H264_SPS_MAX_NUM_REF_FRAMES",
-    "VIDEO_MSE_BUFFERING_COUNT",
     "VIDEO_MSE_PLAY_TIME_MS",
     "VIDEO_MSE_UNLOAD_STATE",
     "VIDEO_OPENH264_GMP_DISAPPEARED",
     "VIDEO_OPENH264_GMP_MISSING_FILES",
     "VIEW_SOURCE_EXTERNAL_RESULT_BOOLEAN",
     "VIEW_SOURCE_IN_BROWSER_OPENED_BOOLEAN",
     "VIEW_SOURCE_IN_WINDOW_OPENED_BOOLEAN",
     "WEAVE_COMPLETE_SUCCESS_COUNT",