Bug 1264534 - Apply all visibility wrappers or none, r?glandium draft
authorMartin Thomson <martin.thomson@gmail.com>
Thu, 21 Apr 2016 09:48:55 +1000
changeset 354486 8e371c84a2b3f9ad26ab22bb747a564da0baadcf
parent 352861 67ac40fb8f680ea5e03805552187ba1b5e8392a1
child 519014 5c6c2ffaee21f7d4e74e47d3fda39b65c1b9cc76
push id16090
push userbmo:martin.thomson@gmail.com
push dateWed, 20 Apr 2016 23:57:29 +0000
reviewersglandium
bugs1264534
milestone48.0a1
Bug 1264534 - Apply all visibility wrappers or none, r?glandium When wrapping system headers to apply visibility tweaks, both the STL and standard system headers need to be wrapped at the same time. For instance, libstdc++ 6 <cmath> calls include_next for <math.h>. This results in the wrapper for <math.h> and its visibility changes are consequently not applied. MozReview-Commit-ID: KlJvkelHVMt
config/config.mk
--- a/config/config.mk
+++ b/config/config.mk
@@ -324,17 +324,17 @@ endif # CLANG_CL
 # Use warnings-as-errors if ALLOW_COMPILER_WARNINGS is not set to 1 (which
 # includes the case where it's undefined).
 ifneq (1,$(ALLOW_COMPILER_WARNINGS))
 CXXFLAGS += $(WARNINGS_AS_ERRORS)
 CFLAGS   += $(WARNINGS_AS_ERRORS)
 endif # ALLOW_COMPILER_WARNINGS
 
 COMPILE_CFLAGS	= $(VISIBILITY_FLAGS) $(DEFINES) $(INCLUDES) $(OS_INCLUDES) $(DSO_CFLAGS) $(DSO_PIC_CFLAGS) $(RTL_FLAGS) $(OS_COMPILE_CFLAGS) $(_DEPEND_CFLAGS) $(CFLAGS) $(MOZBUILD_CFLAGS)
-COMPILE_CXXFLAGS = $(if $(DISABLE_STL_WRAPPING),,$(STL_FLAGS)) $(VISIBILITY_FLAGS) $(DEFINES) $(INCLUDES) $(OS_INCLUDES) $(DSO_CFLAGS) $(DSO_PIC_CFLAGS) $(RTL_FLAGS) $(OS_COMPILE_CXXFLAGS) $(_DEPEND_CFLAGS) $(CXXFLAGS) $(MOZBUILD_CXXFLAGS)
+COMPILE_CXXFLAGS = $(if $(DISABLE_STL_WRAPPING),,$(STL_FLAGS) $(VISIBILITY_FLAGS)) $(DEFINES) $(INCLUDES) $(OS_INCLUDES) $(DSO_CFLAGS) $(DSO_PIC_CFLAGS) $(RTL_FLAGS) $(OS_COMPILE_CXXFLAGS) $(_DEPEND_CFLAGS) $(CXXFLAGS) $(MOZBUILD_CXXFLAGS)
 COMPILE_CMFLAGS = $(OS_COMPILE_CMFLAGS) $(MOZBUILD_CMFLAGS)
 COMPILE_CMMFLAGS = $(OS_COMPILE_CMMFLAGS) $(MOZBUILD_CMMFLAGS)
 ASFLAGS += $(MOZBUILD_ASFLAGS)
 
 ifndef CROSS_COMPILE
 HOST_CFLAGS += $(RTL_FLAGS)
 endif