mozreviewbots: add author output to tests (Bug 1266244). r?glob draft
authorSteven MacLeod <smacleod@mozilla.com>
Wed, 20 Apr 2016 19:40:45 -0400
changeset 7824 87c6b9ec48c541401dcafdae50af2b57ff9cc143
parent 7823 7a6d49497723ae9c82f6d69bfb9b966cd83870f0
push id760
push usersmacleod@mozilla.com
push dateWed, 20 Apr 2016 23:43:25 +0000
reviewersglob
bugs1266244
mozreviewbots: add author output to tests (Bug 1266244). r?glob Some of the recent changes to MozReview missed updating the mozreviewbots tests. The tests should now pass after this change. MozReview-Commit-ID: JS8RdkJBTYH
pylib/mozreviewbots/tests/test-eslintbot-noop.t
pylib/mozreviewbots/tests/test-eslintbot.t
pylib/mozreviewbots/tests/test-pylintbot-diff-context.t
pylib/mozreviewbots/tests/test-pylintbot-line-adjustment.t
pylib/mozreviewbots/tests/test-pylintbot-noop.t
pylib/mozreviewbots/tests/test-pylintbot.t
pylib/mozreviewbots/tests/test-snarkbot.t
--- a/pylib/mozreviewbots/tests/test-eslintbot-noop.t
+++ b/pylib/mozreviewbots/tests/test-eslintbot-noop.t
@@ -53,16 +53,17 @@ Create a review request that doesn't tou
   - Bug 1 - No Javascript changes
   - ''
   - 'MozReview-Commit-ID: 124Bxg'
   target_people: []
   extra_data:
     calculated_trophies: true
   commit_extra_data:
     p2rb: true
+    p2rb.author: test
     p2rb.commit_id: 27ed10e6e90a514ad461a5a7147a9134de0ca799
     p2rb.first_public_ancestor: dc42edca6edd9dd5a8346b1a881281263d3a10ad
     p2rb.identifier: bz://1/mynick
     p2rb.is_squashed: false
   diffs:
   - id: 2
     revision: 1
     base_commit_id: dc42edca6edd9dd5a8346b1a881281263d3a10ad
--- a/pylib/mozreviewbots/tests/test-eslintbot.t
+++ b/pylib/mozreviewbots/tests/test-eslintbot.t
@@ -57,16 +57,17 @@ Create a review request with some busted
   - Bug 1 - Some busted Javascript
   - ''
   - 'MozReview-Commit-ID: 124Bxg'
   target_people: []
   extra_data:
     calculated_trophies: true
   commit_extra_data:
     p2rb: true
+    p2rb.author: test
     p2rb.commit_id: 719ed7ed9e3e1a340f443981aa91125b68598369
     p2rb.first_public_ancestor: 7c5bdf0cec4a90edb36300f8f3679857f46db829
     p2rb.identifier: bz://1/mynick
     p2rb.is_squashed: false
   diffs:
   - id: 2
     revision: 1
     base_commit_id: 7c5bdf0cec4a90edb36300f8f3679857f46db829
@@ -110,17 +111,17 @@ Create a review request with some busted
     diff_comments:
     - id: 1
       public: true
       user: eslintbot
       issue_opened: true
       issue_status: open
       first_line: 1
       num_lines: 1
-      text: 'Error - Parsing error: Unexpected token { (column 10)'
+      text: 'Error - Parsing error: Unexpected token { (column 9)'
       text_type: plain
       diff_id: 6
       diff_dest_file: test.js
     diff_count: 1
 
 Cleanup
 
   $ mozreview stop
--- a/pylib/mozreviewbots/tests/test-pylintbot-diff-context.t
+++ b/pylib/mozreviewbots/tests/test-pylintbot-diff-context.t
@@ -49,16 +49,17 @@ be ignored
   - Bug 1 - Verify diff context
   - ''
   - 'MozReview-Commit-ID: 124Bxg'
   target_people: []
   extra_data:
     calculated_trophies: true
   commit_extra_data:
     p2rb: true
+    p2rb.author: test
     p2rb.commit_id: 3a773b9e226cc5486fdd724372938f77204ff12c
     p2rb.first_public_ancestor: 3edbb5ae6222fc9890db26538597a9b417cb7b94
     p2rb.identifier: bz://1/mynick
     p2rb.is_squashed: false
   diffs:
   - id: 2
     revision: 1
     base_commit_id: 3edbb5ae6222fc9890db26538597a9b417cb7b94
--- a/pylib/mozreviewbots/tests/test-pylintbot-line-adjustment.t
+++ b/pylib/mozreviewbots/tests/test-pylintbot-line-adjustment.t
@@ -96,16 +96,17 @@ Line numbers for these failures should b
   - Bug 1 - Line adjustment minus 1
   - ''
   - 'MozReview-Commit-ID: 124Bxg'
   target_people: []
   extra_data:
     calculated_trophies: true
   commit_extra_data:
     p2rb: true
+    p2rb.author: test
     p2rb.commit_id: c45aead0c4d66a05a22fce427658fba6f3e20f9c
     p2rb.first_public_ancestor: 7c5bdf0cec4a90edb36300f8f3679857f46db829
     p2rb.identifier: bz://1/mynick
     p2rb.is_squashed: false
   diffs:
   - id: 2
     revision: 1
     base_commit_id: 7c5bdf0cec4a90edb36300f8f3679857f46db829
@@ -304,16 +305,17 @@ Create tests for line -= 2
   - Bug 2 - Line adjustment minus 2
   - ''
   - 'MozReview-Commit-ID: 5ijR9k'
   target_people: []
   extra_data:
     calculated_trophies: true
   commit_extra_data:
     p2rb: true
+    p2rb.author: test
     p2rb.commit_id: 51dfa0ded22aa53d3e7c3d7b5342ba8734c4c6ce
     p2rb.first_public_ancestor: 7c5bdf0cec4a90edb36300f8f3679857f46db829
     p2rb.identifier: bz://2/mynick
     p2rb.is_squashed: false
   diffs:
   - id: 4
     revision: 1
     base_commit_id: 7c5bdf0cec4a90edb36300f8f3679857f46db829
--- a/pylib/mozreviewbots/tests/test-pylintbot-noop.t
+++ b/pylib/mozreviewbots/tests/test-pylintbot-noop.t
@@ -31,16 +31,17 @@ No review should be left if no Python fi
   - Bug 1 - No Python changes
   - ''
   - 'MozReview-Commit-ID: 124Bxg'
   target_people: []
   extra_data:
     calculated_trophies: true
   commit_extra_data:
     p2rb: true
+    p2rb.author: test
     p2rb.commit_id: 97bc3c7259dfe4c83e2d1ac3e6b252a5331da9cd
     p2rb.first_public_ancestor: 7c5bdf0cec4a90edb36300f8f3679857f46db829
     p2rb.identifier: bz://1/mynick
     p2rb.is_squashed: false
   diffs:
   - id: 2
     revision: 1
     base_commit_id: 7c5bdf0cec4a90edb36300f8f3679857f46db829
--- a/pylib/mozreviewbots/tests/test-pylintbot.t
+++ b/pylib/mozreviewbots/tests/test-pylintbot.t
@@ -35,16 +35,17 @@ Create a review with Python style violat
   - Bug 1 - Bad Python
   - ''
   - 'MozReview-Commit-ID: 124Bxg'
   target_people: []
   extra_data:
     calculated_trophies: true
   commit_extra_data:
     p2rb: true
+    p2rb.author: test
     p2rb.commit_id: 1978e5417012a5f63128d09cfd52c52077c761cb
     p2rb.first_public_ancestor: 7c5bdf0cec4a90edb36300f8f3679857f46db829
     p2rb.identifier: bz://1/mynick
     p2rb.is_squashed: false
   diffs:
   - id: 2
     revision: 1
     base_commit_id: 7c5bdf0cec4a90edb36300f8f3679857f46db829
@@ -143,16 +144,17 @@ Ensure pyflakes warnings are handled
   - Bug 2 - pyflakes
   - ''
   - 'MozReview-Commit-ID: 5ijR9k'
   target_people: []
   extra_data:
     calculated_trophies: true
   commit_extra_data:
     p2rb: true
+    p2rb.author: test
     p2rb.commit_id: c768227fc261de5a93e0c813e0ba4a54e24d2697
     p2rb.first_public_ancestor: 7c5bdf0cec4a90edb36300f8f3679857f46db829
     p2rb.identifier: bz://2/mynick
     p2rb.is_squashed: false
   diffs:
   - id: 4
     revision: 1
     base_commit_id: 7c5bdf0cec4a90edb36300f8f3679857f46db829
--- a/pylib/mozreviewbots/tests/test-snarkbot.t
+++ b/pylib/mozreviewbots/tests/test-snarkbot.t
@@ -93,16 +93,17 @@ Create and publish a review for SnarkBot
   - Bug 1 - Foo 1
   - ''
   - 'MozReview-Commit-ID: 124Bxg'
   target_people: []
   extra_data:
     calculated_trophies: true
   commit_extra_data:
     p2rb: true
+    p2rb.author: test
     p2rb.commit_id: 729692c35796d9cbd453ccef97ee0d14139c4a09
     p2rb.first_public_ancestor: 7c5bdf0cec4a90edb36300f8f3679857f46db829
     p2rb.identifier: bz://1/mynick
     p2rb.is_squashed: false
   diffs:
   - id: 2
     revision: 1
     base_commit_id: 7c5bdf0cec4a90edb36300f8f3679857f46db829