Bug 1264337 - Add the sync/tabs-from-other-devices tab icon back to awesomebar results. r?mak draft
authorDrew Willcoxon <adw@mozilla.com>
Thu, 14 Apr 2016 14:08:26 -0700
changeset 351691 4bbcef3887b8f65a5a2d14359adb9af64f252049
parent 351690 e349f61f356cd9542a41a42b14a0c85f1e347fa1
child 518483 325c9653f5fe4fa0f5adba4afb887e9e545624aa
push id15507
push userdwillcoxon@mozilla.com
push dateThu, 14 Apr 2016 21:08:39 +0000
reviewersmak
bugs1264337
milestone48.0a1
Bug 1264337 - Add the sync/tabs-from-other-devices tab icon back to awesomebar results. r?mak The redesign bug removed some CSS that matched actiontype$=tab, and for styling the type icon it also replaced actiontype with just type. MozReview-Commit-ID: 68OBIFPtdFP
browser/themes/linux/browser.css
browser/themes/osx/browser.css
browser/themes/windows/browser.css
toolkit/content/widgets/autocomplete.xml
--- a/browser/themes/linux/browser.css
+++ b/browser/themes/linux/browser.css
@@ -1187,21 +1187,23 @@ html|span.ac-tag {
 }
 
 .autocomplete-treebody::-moz-tree-image(tag, treecolAutoCompleteImage) {
   list-style-image: url("chrome://browser/skin/places/tag.png");
   width: 16px;
   height: 16px;
 }
 
-.ac-type-icon[type=switchtab] {
+.ac-type-icon[type=switchtab],
+.ac-type-icon[type=remotetab] {
   list-style-image: url("chrome://browser/skin/urlbar-tab.svg#tab");
 }
 
-.ac-type-icon[type=switchtab][selected] {
+.ac-type-icon[type=switchtab][selected],
+.ac-type-icon[type=remotetab][selected] {
   list-style-image: url("chrome://browser/skin/urlbar-tab.svg#tab-inverted");
 }
 
 .autocomplete-treebody::-moz-tree-cell-text(treecolAutoCompleteComment) {
   color: GrayText;
 }
 
 .autocomplete-treebody::-moz-tree-cell-text(suggesthint, treecolAutoCompleteComment),
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -1830,21 +1830,23 @@ html|span.ac-emphasize-text-url {
 .autocomplete-treebody::-moz-tree-image(keyword, treecolAutoCompleteImage, selected) {
   list-style-image: url(chrome://global/skin/icons/autocomplete-search.svg#search-icon-inverted);
 }
 
 .autocomplete-treebody::-moz-tree-image(tag, treecolAutoCompleteImage) {
   list-style-image: url("chrome://browser/skin/places/tag.png");
 }
 
-.ac-type-icon[type=switchtab] {
+.ac-type-icon[type=switchtab],
+.ac-type-icon[type=remotetab] {
   list-style-image: url("chrome://browser/skin/urlbar-tab.svg#tab");
 }
 
-.ac-type-icon[type=switchtab][selected] {
+.ac-type-icon[type=switchtab][selected],
+.ac-type-icon[type=remotetab][selected] {
   list-style-image: url("chrome://browser/skin/urlbar-tab.svg#tab-inverted");
 }
 
 .autocomplete-treebody::-moz-tree-cell-text(treecolAutoCompleteComment) {
   color: GrayText;
 }
 
 .autocomplete-treebody::-moz-tree-cell-text(suggesthint, treecolAutoCompleteComment),
--- a/browser/themes/windows/browser.css
+++ b/browser/themes/windows/browser.css
@@ -1573,21 +1573,23 @@ html|span.ac-emphasize-text-url {
 }
 
 .autocomplete-treebody::-moz-tree-image(tag, treecolAutoCompleteImage) {
   list-style-image: url("chrome://browser/skin/places/tag.png");
   width: 16px;
   height: 16px;
 }
 
-.ac-type-icon[type=switchtab] {
+.ac-type-icon[type=switchtab],
+.ac-type-icon[type=remotetab] {
   list-style-image: url("chrome://browser/skin/urlbar-tab.svg#tab");
 }
 
-.ac-type-icon[type=switchtab][selected] {
+.ac-type-icon[type=switchtab][selected],
+.ac-type-icon[type=remotetab][selected] {
   list-style-image: url("chrome://browser/skin/urlbar-tab.svg#tab-inverted");
 }
 
 .autocomplete-treebody::-moz-tree-cell-text(treecolAutoCompleteComment) {
   color: GrayText;
 }
 
 .autocomplete-treebody::-moz-tree-cell-text(suggesthint, treecolAutoCompleteComment),
--- a/toolkit/content/widgets/autocomplete.xml
+++ b/toolkit/content/widgets/autocomplete.xml
@@ -1872,16 +1872,17 @@ extends="chrome://global/content/binding
             this.setAttribute("actiontype", action.type);
 
             if (action.type == "switchtab") {
               this.classList.add("overridable-action");
               displayUrl = this._unescapeUrl(action.params.url);
               let desc = this._stringBundle.GetStringFromName("switchToTab2");
               this._setUpDescription(this._actionText, desc, true);
             } else if (action.type == "remotetab") {
+              type = "remotetab";
               displayUrl = this._unescapeUrl(action.params.url);
               let desc = action.params.deviceName;
               this._setUpDescription(this._actionText, desc, true);
             } else if (action.type == "searchengine") {
               emphasiseUrl = false;
 
               // The order here is not localizable, we default to appending
               // "- Search with Engine" to the search string, to be able to