Bug 1264725 - Isolate Troubleshoot.jsm (about:support) from addons with null names. r?felipe draft
authorBenjamin Smedberg <benjamin@smedbergs.us>
Thu, 14 Apr 2016 13:48:44 -0400
changeset 351030 42382b94c26dee4d8219af5e91e378708c724c34
parent 350152 b2bc8ace9ca2680b2322eab29cddf6ee48d5d818
child 518458 36799b4181c130cbddd27c73365e0de864233096
push id15481
push userbsmedberg@mozilla.com
push dateThu, 14 Apr 2016 17:53:17 +0000
reviewersfelipe
bugs1264725
milestone48.0a1
Bug 1264725 - Isolate Troubleshoot.jsm (about:support) from addons with null names. r?felipe MozReview-Commit-ID: IKDgMKlf8tc
toolkit/modules/Troubleshoot.jsm
--- a/toolkit/modules/Troubleshoot.jsm
+++ b/toolkit/modules/Troubleshoot.jsm
@@ -238,17 +238,21 @@ var dataProviders = {
     done(data);
   },
 
   extensions: function extensions(done) {
     AddonManager.getAddonsByTypes(["extension"], function (extensions) {
       extensions.sort(function (a, b) {
         if (a.isActive != b.isActive)
           return b.isActive ? 1 : -1;
-        let lc = a.name.localeCompare(b.name);
+
+        // In some unfortunate cases addon names can be null.
+        let aname = a.name || null;
+        let bname = b.name || null;
+        let lc = aname.localeCompare(bname);
         if (lc != 0)
           return lc;
         if (a.version != b.version)
           return a.version > b.version ? 1 : -1;
         return 0;
       });
       let props = ["name", "version", "isActive", "id"];
       done(extensions.map(function (ext) {