Bug 1262970 - Change PRINCIPAL_HANDLE_NONE to a nullptr #define. r?nfroyd draft
authorAndreas Pehrson <pehrsons@gmail.com>
Thu, 14 Apr 2016 11:39:11 +0200
changeset 350822 2c9081d0e2f16876da20f0d27b000fa2d1733150
parent 350821 31a5a2721fd57c9e0c563489001c1c6524858e03
child 518410 142e625809177cac8fbc9740049d3723ad1d8f8c
push id15422
push userpehrsons@gmail.com
push dateThu, 14 Apr 2016 09:41:25 +0000
reviewersnfroyd
bugs1262970
milestone48.0a1
Bug 1262970 - Change PRINCIPAL_HANDLE_NONE to a nullptr #define. r?nfroyd MozReview-Commit-ID: A69mWTDTkkP
dom/media/MediaSegment.h
media/webrtc/signaling/test/FakeMediaStreamsImpl.h
--- a/dom/media/MediaSegment.h
+++ b/dom/media/MediaSegment.h
@@ -66,17 +66,17 @@ typedef nsMainThreadPtrHandle<nsIPrincip
 
 inline PrincipalHandle MakePrincipalHandle(nsIPrincipal* aPrincipal)
 {
   RefPtr<nsMainThreadPtrHolder<nsIPrincipal>> holder =
     new nsMainThreadPtrHolder<nsIPrincipal>(aPrincipal);
   return PrincipalHandle(holder);
 }
 
-const PrincipalHandle PRINCIPAL_HANDLE_NONE(nullptr);
+#define PRINCIPAL_HANDLE_NONE nullptr
 
 inline nsIPrincipal* GetPrincipalFromHandle(PrincipalHandle& aPrincipalHandle)
 {
   MOZ_ASSERT(NS_IsMainThread());
   return aPrincipalHandle.get();
 }
 
 inline bool PrincipalHandleMatches(PrincipalHandle& aPrincipalHandle,
--- a/media/webrtc/signaling/test/FakeMediaStreamsImpl.h
+++ b/media/webrtc/signaling/test/FakeMediaStreamsImpl.h
@@ -116,17 +116,17 @@ void Fake_AudioStreamSource::Periodic() 
   }
 
   mozilla::AudioSegment segment;
   AutoTArray<const int16_t *,1> channels;
   channels.AppendElement(data);
   segment.AppendFrames(samples.forget(),
                        channels,
                        AUDIO_BUFFER_SIZE,
-                       mozilla::PRINCIPAL_HANDLE_NONE);
+                       PRINCIPAL_HANDLE_NONE);
 
   for(std::set<RefPtr<Fake_MediaStreamListener>>::iterator it = mListeners.begin();
        it != mListeners.end(); ++it) {
     (*it)->NotifyQueuedTrackChanges(nullptr, // Graph
                                     0, // TrackID
                                     0, // Offset TODO(ekr@rtfm.com) fix
                                     0, // ???
                                     segment,