Bug 1261474 - Remove custom install rules in browser/app/Makefile.in; r?chmanchester draft
authorMike Shal <mshal@mozilla.com>
Thu, 31 Mar 2016 17:12:11 -0400
changeset 347079 10c08e6db2a678395920e420c55eb1cb44a0afb3
parent 347078 dbf9180173509633d9fe14a893161c5111973dcf
child 517532 d8f7fec206acc1fdbe826b8acdd0878750c6d5a5
push id14476
push userbmo:mshal@mozilla.com
push dateFri, 01 Apr 2016 21:01:04 +0000
reviewerschmanchester
bugs1261474
milestone48.0a1
Bug 1261474 - Remove custom install rules in browser/app/Makefile.in; r?chmanchester MozReview-Commit-ID: K2FTdBaIWPI
browser/app/Makefile.in
browser/app/moz.build
--- a/browser/app/Makefile.in
+++ b/browser/app/Makefile.in
@@ -41,24 +41,16 @@ ifdef COMPILE_ENVIRONMENT
 libs:: 
 	cp -p $(MOZ_APP_NAME)$(BIN_SUFFIX) $(DIST)/bin/$(MOZ_APP_NAME)-bin$(BIN_SUFFIX)
 endif
 
 GARBAGE += $(addprefix $(FINAL_TARGET)/defaults/pref/, firefox.js)
 
 endif
 
-ifneq (,$(filter gtk%,$(MOZ_WIDGET_TOOLKIT)))
-libs::
-	$(INSTALL) $(IFLAGS1) $(DIST)/branding/mozicon128.png $(FINAL_TARGET)/icons
-	$(INSTALL) $(IFLAGS1) $(DIST)/branding/default16.png  $(FINAL_TARGET)/chrome/icons/default
-	$(INSTALL) $(IFLAGS1) $(DIST)/branding/default32.png  $(FINAL_TARGET)/chrome/icons/default
-	$(INSTALL) $(IFLAGS1) $(DIST)/branding/default48.png  $(FINAL_TARGET)/chrome/icons/default
-endif
-
 # channel-prefs.js is handled separate from other prefs due to bug 756325
 libs:: $(srcdir)/profile/channel-prefs.js
 	$(NSINSTALL) -D $(DIST)/bin/defaults/pref
 	$(call py_action,preprocessor,-Fsubstitution $(PREF_PPFLAGS) $(ACDEFINES) $^ -o $(DIST)/bin/defaults/pref/channel-prefs.js)
 
 ifeq (cocoa,$(MOZ_WIDGET_TOOLKIT))
 
 MAC_APP_NAME = $(MOZ_APP_DISPLAYNAME)
--- a/browser/app/moz.build
+++ b/browser/app/moz.build
@@ -18,16 +18,24 @@ JS_PREFERENCE_PP_FILES += [
 SOURCES += [
     'nsBrowserApp.cpp',
 ]
 
 FINAL_TARGET_FILES += ['blocklist.xml']
 FINAL_TARGET_FILES.defaults.profile += ['profile/prefs.js']
 FINAL_TARGET_FILES.defaults += ['permissions']
 
+if 'gtk' in CONFIG['MOZ_WIDGET_TOOLKIT']:
+    FINAL_TARGET_FILES.icons += ['!/dist/branding/mozicon128.png']
+    FINAL_TARGET_FILES.chrome.icons.default += [
+        '!/dist/branding/default16.png',
+        '!/dist/branding/default32.png',
+        '!/dist/branding/default48.png',
+    ]
+
 DEFINES['APP_VERSION'] = CONFIG['MOZ_APP_VERSION']
 
 LOCAL_INCLUDES += [
     '!/build',
     '/toolkit/xre',
     '/xpcom/base',
     '/xpcom/build',
 ]