--- a/Makefile.in
+++ b/Makefile.in
@@ -274,22 +274,18 @@ DUMP_SYMS_BIN ?= $(DIST)/host/bin/dump_s
MAKE_SYM_STORE_PATH := $(DIST)/bin
endif
MAKE_SYM_STORE_ARGS += --install-manifest=$(DEPTH)/_build_manifests/install/dist_include,$(DIST)/include
SYM_STORE_SOURCE_DIRS := $(topsrcdir)
include $(topsrcdir)/toolkit/mozapps/installer/package-name.mk
-ifdef MOZ_SYMBOLS_EXTRA_BUILDID
-EXTRA_BUILDID := -$(MOZ_SYMBOLS_EXTRA_BUILDID)
-endif
-
SYMBOL_INDEX_NAME = \
- $(MOZ_APP_NAME)-$(MOZ_APP_VERSION)-$(OS_TARGET)-$(BUILDID)-$(CPU_ARCH)$(EXTRA_BUILDID)-symbols.txt
+ $(MOZ_APP_NAME)-$(MOZ_APP_VERSION)-$(OS_TARGET)-$(BUILDID)-$(CPU_ARCH)-symbols.txt
buildsymbols:
ifdef MOZ_CRASHREPORTER
echo building symbol store
$(RM) -r $(DIST)/crashreporter-symbols
$(RM) '$(DIST)/$(SYMBOL_ARCHIVE_BASENAME).zip'
$(RM) '$(DIST)/$(SYMBOL_FULL_ARCHIVE_BASENAME).zip'
$(NSINSTALL) -D $(DIST)/crashreporter-symbols
--- a/testing/mozharness/configs/builds/branch_specifics.py
+++ b/testing/mozharness/configs/builds/branch_specifics.py
@@ -29,25 +29,23 @@
# }
config = {
### release branches
"mozilla-central": {
"repo_path": 'mozilla-central',
"update_channel": "nightly",
"graph_server_branch_name": "Firefox",
- 'use_branch_in_symbols_extra_buildid': False,
'stage_server': 'upload.ffxbld.productdelivery.prod.mozaws.net',
},
'mozilla-release': {
'enable_release_promotion': True,
'repo_path': 'releases/mozilla-release',
'update_channel': 'release',
'branch_uses_per_checkin_strategy': True,
- 'use_branch_in_symbols_extra_buildid': False,
'stage_server': 'upload.ffxbld.productdelivery.prod.mozaws.net',
'platform_overrides': {
'linux': {
'src_mozconfig': 'browser/config/mozconfigs/linux32/release',
},
'linux64': {
'src_mozconfig': 'browser/config/mozconfigs/linux64/release',
},
@@ -107,17 +105,16 @@ config = {
},
},
},
'mozilla-beta': {
'enable_release_promotion': 1,
'repo_path': 'releases/mozilla-beta',
'update_channel': 'beta',
'branch_uses_per_checkin_strategy': True,
- 'use_branch_in_symbols_extra_buildid': False,
'stage_server': 'upload.ffxbld.productdelivery.prod.mozaws.net',
'platform_overrides': {
'linux': {
'src_mozconfig': 'browser/config/mozconfigs/linux32/beta',
},
'linux64': {
'src_mozconfig': 'browser/config/mozconfigs/linux64/beta',
},
@@ -176,28 +173,26 @@ config = {
'update_channel': 'default',
},
},
},
'mozilla-aurora': {
'repo_path': 'releases/mozilla-aurora',
'update_channel': 'aurora',
'branch_uses_per_checkin_strategy': True,
- 'use_branch_in_symbols_extra_buildid': False,
'stage_server': 'upload.ffxbld.productdelivery.prod.mozaws.net',
},
'try': {
'repo_path': 'try',
'clone_by_revision': True,
'clone_with_purge': True,
'tinderbox_build_dir': '%(who)s-%(got_revision)s',
'to_tinderbox_dated': False,
'include_post_upload_builddir': True,
'release_to_try_builds': True,
- 'use_branch_in_symbols_extra_buildid': False,
'stage_server': 'upload.trybld.productdelivery.prod.mozaws.net',
'stage_username': 'trybld',
'stage_ssh_key': 'trybld_dsa',
'branch_supports_uploadsymbols': False,
'use_clobberer': False,
},
### project branches
--- a/testing/mozharness/configs/builds/releng_base_linux_64_builds.py
+++ b/testing/mozharness/configs/builds/releng_base_linux_64_builds.py
@@ -72,17 +72,16 @@ config = {
#########################################################################
###### 64 bit specific ######
'base_name': 'Linux_x86-64_%(branch)s',
'platform': 'linux64',
'stage_platform': 'linux64',
'publish_nightly_en_US_routes': True,
- 'use_platform_in_symbols_extra_buildid': True,
'env': {
'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),
'MOZ_AUTOMATION': '1',
'DISPLAY': ':2',
'HG_SHARE_BASE_DIR': '/builds/hg-shared',
'MOZ_OBJDIR': 'obj-firefox',
# SYMBOL_SERVER_HOST is dictated from build_pool_specifics.py
'SYMBOL_SERVER_HOST': '%(symbol_server_host)s',
--- a/testing/mozharness/configs/builds/releng_base_mac_64_builds.py
+++ b/testing/mozharness/configs/builds/releng_base_mac_64_builds.py
@@ -40,17 +40,16 @@ config = {
#########################################################################
###### 64 bit specific ######
'base_name': 'OS X 10.7 %(branch)s',
'platform': 'macosx64',
'stage_platform': 'macosx64',
'publish_nightly_en_US_routes': True,
- 'use_platform_in_symbols_extra_buildid': True,
'env': {
'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),
'MOZ_AUTOMATION': '1',
'HG_SHARE_BASE_DIR': '/builds/hg-shared',
'MOZ_OBJDIR': 'obj-firefox',
# SYMBOL_SERVER_HOST is dictated from build_pool_specifics.py
'SYMBOL_SERVER_HOST': '%(symbol_server_host)s',
'SYMBOL_SERVER_SSH_KEY': "/Users/cltbld/.ssh/ffxbld_rsa",
--- a/testing/mozharness/configs/builds/releng_base_mac_64_cross_builds.py
+++ b/testing/mozharness/configs/builds/releng_base_mac_64_cross_builds.py
@@ -37,17 +37,16 @@ config = {
#########################################################################
#########################################################################
###### 64 bit specific ######
'base_name': 'OS X 10.7 %(branch)s',
'platform': 'macosx64',
'stage_platform': 'macosx64',
- 'use_platform_in_symbols_extra_buildid': True,
'env': {
'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),
'MOZ_AUTOMATION': '1',
'HG_SHARE_BASE_DIR': '/builds/hg-shared',
'MOZ_OBJDIR': 'obj-firefox',
# SYMBOL_SERVER_HOST is dictated from build_pool_specifics.py
'SYMBOL_SERVER_HOST': '%(symbol_server_host)s',
'SYMBOL_SERVER_SSH_KEY': "/Users/cltbld/.ssh/ffxbld_rsa",
--- a/testing/mozharness/configs/builds/releng_base_windows_64_builds.py
+++ b/testing/mozharness/configs/builds/releng_base_windows_64_builds.py
@@ -63,17 +63,16 @@ config = {
#########################################################################
###### 64 bit specific ######
'base_name': 'WINNT_6.1_x86-64_%(branch)s',
'platform': 'win64',
'stage_platform': 'win64',
'publish_nightly_en_US_routes': True,
'env': {
- 'MOZ_SYMBOLS_EXTRA_BUILDID': 'win64',
'MOZ_AUTOMATION': '1',
'HG_SHARE_BASE_DIR': 'C:/builds/hg-shared',
'MOZ_CRASHREPORTER_NO_REPORT': '1',
'MOZ_OBJDIR': 'obj-firefox',
'PATH': 'C:/mozilla-build/nsis-3.0b1;C:/mozilla-build/python27;'
'C:/mozilla-build/buildbotve/scripts;'
'%s' % (os.environ.get('path')),
'PDBSTR_PATH': '/c/Program Files (x86)/Windows Kits/8.0/Debuggers/x64/srcsrv/pdbstr.exe',
--- a/testing/mozharness/configs/builds/releng_sub_linux_configs/64_artifact.py
+++ b/testing/mozharness/configs/builds/releng_sub_linux_configs/64_artifact.py
@@ -29,17 +29,16 @@ config = {
#########################################################################
###### 64 bit specific ######
'base_name': 'Linux_x86-64_%(branch)s_Artifact_build',
'platform': 'linux64',
'stage_platform': 'linux64',
'publish_nightly_en_US_routes': False,
- 'use_platform_in_symbols_extra_buildid': True,
'env': {
'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),
'MOZ_AUTOMATION': '1',
'DISPLAY': ':2',
'HG_SHARE_BASE_DIR': '/builds/hg-shared',
'MOZ_OBJDIR': 'obj-firefox',
'TINDERBOX_OUTPUT': '1',
'TOOLTOOL_CACHE': '/builds/tooltool_cache',
--- a/testing/mozharness/configs/builds/releng_sub_linux_configs/64_stat_and_opt.py
+++ b/testing/mozharness/configs/builds/releng_sub_linux_configs/64_stat_and_opt.py
@@ -29,17 +29,16 @@ config = {
#########################################################################
###### 64 bit specific ######
'base_name': 'Linux_x86-64_%(branch)s_Static_Analysis',
'platform': 'linux64',
'stage_platform': 'linux64-st-an',
'publish_nightly_en_US_routes': False,
- 'use_platform_in_symbols_extra_buildid': True,
'env': {
'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),
'MOZ_AUTOMATION': '1',
'DISPLAY': ':2',
'HG_SHARE_BASE_DIR': '/builds/hg-shared',
'MOZ_OBJDIR': 'obj-firefox',
'TINDERBOX_OUTPUT': '1',
'TOOLTOOL_CACHE': '/builds/tooltool_cache',
--- a/testing/mozharness/configs/single_locale/macosx64.py
+++ b/testing/mozharness/configs/single_locale/macosx64.py
@@ -6,17 +6,16 @@ config = {
"stage_product": "firefox",
"update_platform": "Darwin_x86_64-gcc3",
"mozconfig": "%(branch)s/browser/config/mozconfigs/macosx-universal/l10n-mozconfig",
"bootstrap_env": {
"SHELL": '/bin/bash',
"MOZ_OBJDIR": "obj-l10n",
"EN_US_BINARY_URL": "%(en_us_binary_url)s",
"MOZ_UPDATE_CHANNEL": "%(update_channel)s",
- "MOZ_SYMBOLS_EXTRA_BUILDID": "macosx64",
"MOZ_PKG_PLATFORM": "mac",
# "IS_NIGHTLY": "yes",
"DIST": "%(abs_objdir)s",
"LOCALE_MERGEDIR": "%(abs_merge_dir)s/",
"L10NBASEDIR": "../../l10n",
"MOZ_MAKE_COMPLETE_MAR": "1",
"LOCALE_MERGEDIR": "%(abs_merge_dir)s/",
},
--- a/testing/mozharness/mozharness/mozilla/building/buildbase.py
+++ b/testing/mozharness/mozharness/mozilla/building/buildbase.py
@@ -943,38 +943,16 @@ or run without that action (ie: --no-{ac
c = self.config
dirs = self.query_abs_dirs()
check_test_env = {}
if c.get('check_test_env'):
for env_var, env_value in c['check_test_env'].iteritems():
check_test_env[env_var] = env_value % dirs
return check_test_env
- def _query_moz_symbols_buildid(self):
- # this is a bit confusing but every platform that make
- # uploadsymbols may or may not include a
- # MOZ_SYMBOLS_EXTRA_BUILDID in the env and the value of this
- # varies.
- # logic goes:
- # If it's the release branch, we only include it for
- # 64bit platforms and we use just the platform as value.
- # If it's a project branch off m-c, we include only the branch
- # for the value on 32 bit platforms and we include both the
- # platform and branch for 64 bit platforms
- c = self.config
- moz_symbols_extra_buildid = ''
- if c.get('use_platform_in_symbols_extra_buildid'):
- moz_symbols_extra_buildid += self.stage_platform
- if c.get('use_branch_in_symbols_extra_buildid'):
- if moz_symbols_extra_buildid:
- moz_symbols_extra_buildid += '-%s' % (self.branch,)
- else:
- moz_symbols_extra_buildid = self.branch
- return moz_symbols_extra_buildid
-
def _query_who(self):
""" looks for who triggered the build with a change.
This is used for things like try builds where the upload dir is
associated with who pushed to try. First it will look in self.config
and failing that, will poll buildbot_config
If nothing is found, it will default to returning "nobody@example.com"
"""
@@ -1623,19 +1601,16 @@ or run without that action (ie: --no-{ac
if os.path.exists(mach_props):
self.info("Removing previous mach property file: %s" % mach_props)
self.rmtree(mach_props)
def build(self):
"""builds application."""
env = self.query_build_env()
env.update(self.query_mach_build_env())
- symbols_extra_buildid = self._query_moz_symbols_buildid()
- if symbols_extra_buildid:
- env['MOZ_SYMBOLS_EXTRA_BUILDID'] = symbols_extra_buildid
# XXX Bug 1037883 - mozconfigs can not find buildprops.json when builds
# are through mozharness. This is not pretty but it is a stopgap
# until an alternative solution is made or all builds that touch
# mozconfig.cache are converted to mozharness.
dirs = self.query_abs_dirs()
self.copyfile(os.path.join(dirs['base_work_dir'], 'buildprops.json'),
os.path.join(dirs['abs_work_dir'], 'buildprops.json'))
--- a/testing/mozharness/scripts/fx_desktop_build.py
+++ b/testing/mozharness/scripts/fx_desktop_build.py
@@ -66,17 +66,16 @@ class FxDesktopBuild(BuildScript, object
"%(objdir)s/dist/firefox-*",
"%(objdir)s/dist/fennec*",
"%(objdir)s/dist/seamonkey*",
"%(objdir)s/dist/thunderbird*",
"%(objdir)s/dist/install/sea/*.exe"
],
'stage_product': 'firefox',
'platform_supports_post_upload_to_latest': True,
- 'use_branch_in_symbols_extra_buildid': True,
'latest_mar_dir': '/pub/mozilla.org/firefox/nightly/latest-%(branch)s',
'compare_locales_repo': 'https://hg.mozilla.org/build/compare-locales',
'compare_locales_rev': 'RELEASE_AUTOMATION',
'compare_locales_vcs': 'hgtool',
'influx_credentials_file': 'oauth.txt',
'build_resources_path': '%(abs_src_dir)s/obj-firefox/.mozbuild/build_resources.json',
'nightly_promotion_branches': ['mozilla-central', 'mozilla-aurora'],
--- a/testing/taskcluster/scripts/builder/build-linux.sh
+++ b/testing/taskcluster/scripts/builder/build-linux.sh
@@ -30,17 +30,16 @@ set -v
fail() {
echo # make sure error message is on a new line
echo "[build-linux.sh:error]" "${@}"
exit 1
}
export MOZ_CRASHREPORTER_NO_REPORT=1
export MOZ_OBJDIR=obj-firefox
-export MOZ_SYMBOLS_EXTRA_BUILDID=linux64
export TINDERBOX_OUTPUT=1
# use "simple" package names so that they can be hard-coded in the task's
# extras.locations
export MOZ_SIMPLE_PACKAGE_NAME=target
# Ensure that in tree libraries can be found
export LIBRARY_PATH=$LIBRARY_PATH:$WORKSPACE/src/obj-firefox:$WORKSPACE/src/gcc/lib64