Bug 1258916 part 4 - Simplify code for skipping dir when populating test files. r=dbaron
MozReview-Commit-ID: CXDyfTAn5qv
--- a/layout/reftests/w3c-css/import-tests.py
+++ b/layout/reftests/w3c-css/import-tests.py
@@ -101,26 +101,22 @@ def remove_existing_dirs():
for dirname in os.listdir(gDestPath):
fulldir = os.path.join(gDestPath, dirname)
if not os.path.isdir(fulldir):
continue
shutil.rmtree(fulldir)
def populate_test_files():
global gSubtrees, gTestfiles
+ excludeDirs = ["support", "reftest", "reference", "reports", "tools"]
for subtree in gSubtrees:
for dirpath, dirnames, filenames in os.walk(subtree, topdown=True):
- if "support" in dirnames:
- dirnames.remove("support")
- if "reftest" in dirnames:
- dirnames.remove("reftest")
- if "reference" in dirnames:
- dirnames.remove("reference")
- if "reports" in dirnames:
- dirnames.remove("reports")
+ for exclDir in excludeDirs:
+ if exclDir in dirnames:
+ dirnames.remove(exclDir)
for f in filenames:
if f == "README" or \
f.find("-ref.") != -1:
continue
gTestfiles.append(os.path.join(dirpath, f))
gTestfiles.sort()