Bug 1260066 - Move last uses of check_prog that weren't in the global scope to the global scope. r?nalexander draft
authorMike Hommey <mh+mozilla@glandium.org>
Mon, 28 Mar 2016 07:22:09 +0900
changeset 345026 5a5675ddac5b5d1e605c5ae093f3de2564fc9e36
parent 345025 d5534df8ca17bea71780ea162ca9480da32de072
child 345027 56fc7cf310755a571134ad368643a74e891d2f98
push id13998
push userbmo:mh+mozilla@glandium.org
push dateSun, 27 Mar 2016 22:56:08 +0000
reviewersnalexander
bugs1260066
milestone48.0a1
Bug 1260066 - Move last uses of check_prog that weren't in the global scope to the global scope. r?nalexander
moz.configure
--- a/moz.configure
+++ b/moz.configure
@@ -142,21 +142,27 @@ perl_version_check('5.006')
 # ==============================================================
 check_prog('DOXYGEN', ('doxygen',), allow_missing=True)
 check_prog('TAR', ('gnutar', 'gtar', 'tar'))
 check_prog('UNZIP', ('unzip',))
 check_prog('XARGS', ('xargs',))
 check_prog('ZIP', ('zip',))
 
 @depends(target)
-def mac_programs(target):
+def extra_programs(target):
     if target.kernel == 'Darwin':
-        check_prog('DSYMUTIL', ('dsymutil', 'llvm-dsymutil'), allow_missing=True)
-        check_prog('GENISOIMAGE', ('genisoimage',), allow_missing=True)
+        return namespace(
+            DSYMUTIL=('dsymutil', 'llvm-dsymutil'),
+            GENISOIMAGE=('genisoimage',),
+        )
+    if target.os == 'GNU' and target.kernel == 'Linux':
+        return namespace(RPMBUILD=('rpmbuild',))
 
-@depends(target)
-def linux_programs(target):
-    if target.os == 'GNU' and target.kernel == 'Linux':
-        check_prog('RPMBUILD', ('rpmbuild',), allow_missing=True)
+check_prog('DSYMUTIL', delayed_getattr(extra_programs, 'DSYMUTIL'),
+           allow_missing=True)
+check_prog('GENISOIMAGE', delayed_getattr(extra_programs, 'GENISOIMAGE'),
+           allow_missing=True)
+check_prog('RPMBUILD', delayed_getattr(extra_programs, 'RPMBUILD'),
+           allow_missing=True)
 
 
 # Fallthrough to autoconf-based configure
 include('build/moz.configure/old.configure')