Bug 1259676 - part1: rename from 'InternalAnimationEvent.animationName' to 'InternalAnimationEvent.mAnimationName'. r?masayuki draft
authorTetsuharu OHZEKI <saneyuki.snyk@gmail.com>
Sat, 26 Mar 2016 13:37:19 +0900
changeset 344903 c6707d70c17ae455ad8ed289cf3bf2a86c36585a
parent 344766 b2dbee5ca727e87bdaeab9ab60fb83df2a9846a2
child 344904 b3a84318af4b6d489120694eb659e4b28697b19d
push id13957
push userbmo:saneyuki.s.snyk@gmail.com
push dateSat, 26 Mar 2016 04:37:53 +0000
reviewersmasayuki
bugs1259676
milestone48.0a1
Bug 1259676 - part1: rename from 'InternalAnimationEvent.animationName' to 'InternalAnimationEvent.mAnimationName'. r?masayuki MozReview-Commit-ID: DK5Q477WoXu
dom/events/AnimationEvent.cpp
layout/style/nsAnimationManager.h
widget/ContentEvents.h
--- a/dom/events/AnimationEvent.cpp
+++ b/dom/events/AnimationEvent.cpp
@@ -42,28 +42,28 @@ AnimationEvent::Constructor(const Global
 {
   nsCOMPtr<EventTarget> t = do_QueryInterface(aGlobal.GetAsSupports());
   RefPtr<AnimationEvent> e = new AnimationEvent(t, nullptr, nullptr);
   bool trusted = e->Init(t);
 
   e->InitEvent(aType, aParam.mBubbles, aParam.mCancelable);
 
   InternalAnimationEvent* internalEvent = e->mEvent->AsAnimationEvent();
-  internalEvent->animationName = aParam.mAnimationName;
+  internalEvent->mAnimationName = aParam.mAnimationName;
   internalEvent->elapsedTime = aParam.mElapsedTime;
   internalEvent->pseudoElement = aParam.mPseudoElement;
 
   e->SetTrusted(trusted);
   return e.forget();
 }
 
 NS_IMETHODIMP
 AnimationEvent::GetAnimationName(nsAString& aAnimationName)
 {
-  aAnimationName = mEvent->AsAnimationEvent()->animationName;
+  aAnimationName = mEvent->AsAnimationEvent()->mAnimationName;
   return NS_OK;
 }
 
 NS_IMETHODIMP
 AnimationEvent::GetElapsedTime(float* aElapsedTime)
 {
   *aElapsedTime = ElapsedTime();
   return NS_OK;
--- a/layout/style/nsAnimationManager.h
+++ b/layout/style/nsAnimationManager.h
@@ -41,17 +41,17 @@ struct AnimationEventInfo {
                      const TimeStamp& aTimeStamp,
                      dom::Animation* aAnimation)
     : mElement(aElement)
     , mAnimation(aAnimation)
     , mEvent(true, aMessage)
     , mTimeStamp(aTimeStamp)
   {
     // XXX Looks like nobody initialize WidgetEvent::time
-    mEvent.animationName = aAnimationName;
+    mEvent.mAnimationName = aAnimationName;
     mEvent.elapsedTime = aElapsedTime.ToSeconds();
     mEvent.pseudoElement =
       AnimationCollection<dom::CSSAnimation>::PseudoTypeAsString(aPseudoType);
   }
 
   // InternalAnimationEvent doesn't support copy-construction, so we need
   // to ourselves in order to work with nsTArray
   AnimationEventInfo(const AnimationEventInfo& aOther)
--- a/widget/ContentEvents.h
+++ b/widget/ContentEvents.h
@@ -298,26 +298,26 @@ public:
                "Duplicate() must be overridden by sub class");
     InternalAnimationEvent* result =
       new InternalAnimationEvent(false, mMessage);
     result->AssignAnimationEventData(*this, true);
     result->mFlags = mFlags;
     return result;
   }
 
-  nsString animationName;
+  nsString mAnimationName;
   float elapsedTime;
   nsString pseudoElement;
 
   void AssignAnimationEventData(const InternalAnimationEvent& aEvent,
                                 bool aCopyTargets)
   {
     AssignEventData(aEvent, aCopyTargets);
 
-    animationName = aEvent.animationName;
+    mAnimationName = aEvent.mAnimationName;
     elapsedTime = aEvent.elapsedTime;
     pseudoElement = aEvent.pseudoElement;
   }
 };
 
 /******************************************************************************
  * mozilla::InternalSVGZoomEvent
  ******************************************************************************/