Bug 1259557 - Remove some INSTALL_TARGETS from toolkit/mozapps/update/tests/Makefile.in; r?ted
We don't have a way to filter out a file from a wildcard, so we have to
expand data/* in the moz.build file. Alternatively, we could move
xpcshellConstantsPP.js into a separate directory.
MozReview-Commit-ID: 8mOIkr3PeCr
--- a/toolkit/mozapps/update/tests/Makefile.in
+++ b/toolkit/mozapps/update/tests/Makefile.in
@@ -1,47 +1,22 @@
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
XPCSHELLTESTROOT = $(topobjdir)/_tests/xpcshell/$(relativesrcdir)
-CHROMETESTROOT = $(topobjdir)/_tests/testing/mochitest/chrome/$(relativesrcdir)
pp_const_file = $(srcdir)/data/xpcshellConstantsPP.js
PP_TARGETS += aus-test-const
aus-test-const := $(pp_const_file)
aus-test-const_PATH := $(XPCSHELLTESTROOT)/data
aus-test-const_FLAGS := -Fsubstitution $(DEFINES) $(ACDEFINES)
aus-test-const_TARGET := misc
-INSTALL_TARGETS += xpcshell-data
-xpcshell-data_FILES := $(filter-out $(pp_const_file),$(wildcard $(srcdir)/data/*))
-xpcshell-data_DEST := $(XPCSHELLTESTROOT)/data
-xpcshell-data_TARGET := misc
-
-ifndef MOZ_PROFILE_GENERATE
-ifdef COMPILE_ENVIRONMENT
-INSTALL_TARGETS += xpcshell-helper
-xpcshell-helper_FILES := $(DIST)/bin/TestAUSHelper$(BIN_SUFFIX)
-xpcshell-helper_DEST := $(XPCSHELLTESTROOT)/data
-xpcshell-helper_TARGET := misc
-endif
-endif # Not MOZ_PROFILE_GENERATE
-
-_CHROME_DATA := \
- shared.js \
- sharedUpdateXML.js \
- simple.mar \
- $(NULL)
-INSTALL_TARGETS += chrome-data
-chrome-data_FILES := $(addprefix $(srcdir)/data/,$(_CHROME_DATA))
-chrome-data_DEST := $(CHROMETESTROOT)/data
-chrome-data_TARGET := misc
-
INI_TEST_FILES = \
TestAUSReadStrings1.ini \
TestAUSReadStrings2.ini \
TestAUSReadStrings3.ini \
$(NULL)
MOZ_WINCONSOLE = 1
--- a/toolkit/mozapps/update/tests/moz.build
+++ b/toolkit/mozapps/update/tests/moz.build
@@ -1,16 +1,18 @@
# -*- Mode: python; c-basic-offset: 4; indent-tabs-mode: nil; tab-width: 40 -*-
# vim: set filetype=python:
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
HAS_MISC_RULE = True
+FINAL_TARGET = '_tests/xpcshell/toolkit/mozapps/update/tests/data'
+
MOCHITEST_CHROME_MANIFESTS += ['chrome/chrome.ini']
XPCSHELL_TESTS_MANIFESTS += [
'unit_aus_update/xpcshell.ini',
'unit_base_updater/xpcshell.ini'
]
if CONFIG['MOZ_MAINTENANCE_SERVICE']:
@@ -52,8 +54,47 @@ if CONFIG['MOZ_MAINTENANCE_SERVICE']:
#DEFINES['DISABLE_UPDATER_AUTHENTICODE_CHECK'] = True
if CONFIG['OS_ARCH'] == 'WINNT':
DEFINES['UNICODE'] = True
DEFINES['_UNICODE'] = True
USE_STATIC_LIBS = True
if CONFIG['GNU_CC']:
WIN32_EXE_LDFLAGS += ['-municode']
+
+TEST_HARNESS_FILES.testing.mochitest.chrome.toolkit.mozapps.update.tests.data += [
+ 'data/shared.js',
+ 'data/sharedUpdateXML.js',
+ 'data/simple.mar',
+]
+
+FINAL_TARGET_FILES += [
+ 'data/complete.exe',
+ 'data/complete.mar',
+ 'data/complete.png',
+ 'data/complete_log_success',
+ 'data/complete_log_success_mac',
+ 'data/complete_mac.mar',
+ 'data/complete_precomplete',
+ 'data/complete_precomplete_mac',
+ 'data/complete_removed-files',
+ 'data/complete_removed-files_mac',
+ 'data/complete_update_manifest',
+ 'data/old_version.mar',
+ 'data/partial.exe',
+ 'data/partial.mar',
+ 'data/partial.png',
+ 'data/partial_log_failure',
+ 'data/partial_log_failure_mac',
+ 'data/partial_log_success',
+ 'data/partial_log_success_mac',
+ 'data/partial_mac.mar',
+ 'data/partial_precomplete',
+ 'data/partial_precomplete_mac',
+ 'data/partial_removed-files',
+ 'data/partial_removed-files_mac',
+ 'data/partial_update_manifest',
+ 'data/shared.js',
+ 'data/sharedUpdateXML.js',
+ 'data/simple.mar',
+ 'data/wrong_product_channel.mar',
+ 'data/xpcshellUtilsAUS.js',
+]
--- a/toolkit/mozapps/update/updater/updater-xpcshell/Makefile.in
+++ b/toolkit/mozapps/update/updater/updater-xpcshell/Makefile.in
@@ -14,17 +14,17 @@ ifndef MOZ_WINCONSOLE
ifdef MOZ_DEBUG
MOZ_WINCONSOLE = 1
else
MOZ_WINCONSOLE = 0
endif
endif
ifdef COMPILE_ENVIRONMENT
-libs::
+tools::
ifeq (cocoa,$(MOZ_WIDGET_TOOLKIT))
# Copy for xpcshell tests
$(NSINSTALL) -D $(XPCSHELLTESTROOT)/data/updater-xpcshell.app
rsync -a -C --exclude '*.in' $(srcdir)/../macbuild/Contents $(XPCSHELLTESTROOT)/data/updater-xpcshell.app
sed -e 's/%APP_NAME%/$(MOZ_APP_DISPLAYNAME)/' $(srcdir)/../macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in | \
iconv -f UTF-8 -t UTF-16 > $(XPCSHELLTESTROOT)/data/updater-xpcshell.app/Contents/Resources/English.lproj/InfoPlist.strings
$(NSINSTALL) -D $(XPCSHELLTESTROOT)/data/updater-xpcshell.app/Contents/MacOS/updater-xpcshell
$(NSINSTALL) updater-xpcshell $(XPCSHELLTESTROOT)/data/updater-xpcshell.app/Contents/MacOS