Bug 1258430 - Remove readercache item when exiting readermode on bookmarked page draft
authorAndrzej Hunt <ahunt@mozilla.com>
Mon, 07 Mar 2016 14:31:46 -0800
changeset 343517 3d4b36020ddd201ce4f7fd0fa583e8a3e295ee3f
parent 343516 1523fe3f463976d9140d9b6c0e816d90be811cfc
child 516796 63ad446ad3a6743ede7265c2a691ee540b7f47cc
push id13649
push userahunt@mozilla.com
push dateTue, 22 Mar 2016 21:54:45 +0000
bugs1258430
milestone48.0a1
Bug 1258430 - Remove readercache item when exiting readermode on bookmarked page A readermoded bookmark that is currently opened will be in the readercache, if the user exits readermode then we can presume that the user no longer wants to store the readermode version locally. MozReview-Commit-ID: AzTwo8pK8O0
mobile/android/base/java/org/mozilla/gecko/Tab.java
--- a/mobile/android/base/java/org/mozilla/gecko/Tab.java
+++ b/mobile/android/base/java/org/mozilla/gecko/Tab.java
@@ -752,16 +752,18 @@ public class Tab {
 
                 ThumbnailHelper.getInstance().getAndProcessThumbnailFor(tab);
             }
         }, 500);
 
         // Ensure we store bookmarked pages in the readercache if we open them into readermode
         if (success && isBookmark() && AboutPages.isAboutReader(oldURL)) {
             ReadingListHelper.cacheReaderItem(ReaderModeUtils.stripAboutReaderUrl(oldURL), mAppContext);
+        } else if (success && isBookmark() && !AboutPages.isAboutReader(oldURL)) {
+            ReadingListHelper.removeCachedReaderItem(oldURL, mAppContext);
         }
     }
 
     void handleContentLoaded() {
         setLoadProgressIfLoading(LOAD_PROGRESS_LOADED);
     }
 
     protected void saveThumbnailToDB(final BrowserDB db) {