Bug 1258003 - Raise ValueError if video_urls empty; r?maja_zf draft
authorAnjana Vakil <anjanavakil@gmail.com>
Mon, 21 Mar 2016 11:56:38 +0100
changeset 342817 986541262b3dcf4579573ad671105c68535db492
parent 342671 f14898695ee0dd14615914f3e1401f17df57fdd7
child 516627 aa1090929e0ce441efcb6108877002541ddd3ad2
push id13463
push userbmo:anjanavakil@gmail.com
push dateMon, 21 Mar 2016 11:22:44 +0000
reviewersmaja_zf
bugs1258003
milestone48.0a1
Bug 1258003 - Raise ValueError if video_urls empty; r?maja_zf MozReview-Commit-ID: 6YP65VWfGRA
dom/media/test/external/external_media_harness/runtests.py
--- a/dom/media/test/external/external_media_harness/runtests.py
+++ b/dom/media/test/external/external_media_harness/runtests.py
@@ -22,25 +22,27 @@ class MediaTestArgumentsBase(object):
         [['--urls'], {
             'help': 'ini file of urls to make available to all tests',
             'default': os.path.join(external_media_tests.urls, 'default.ini'),
         }],
     ]
 
     def verify_usage_handler(self, args):
         if args.urls:
-           if not os.path.isfile(args.urls):
-               raise ValueError('--urls must provide a path to an ini file')
-           else:
-               path = os.path.abspath(args.urls)
-               args.video_urls = MediaTestArgumentsBase.get_urls(path)
+            if not os.path.isfile(args.urls):
+                raise ValueError('--urls must provide a path to an ini file')
+            else:
+                path = os.path.abspath(args.urls)
+                args.video_urls = MediaTestArgumentsBase.get_urls(path)
+                if not args.video_urls:
+                    raise ValueError('list of video URLs cannot be empty')
 
     def parse_args_handler(self, args):
         if not args.tests:
-           args.tests = [external_media_tests.manifest]
+            args.tests = [external_media_tests.manifest]
 
 
     @staticmethod
     def get_urls(manifest):
         with open(manifest, 'r'):
             return [line[0] for line in read_ini(manifest)]