Bug 1257435 - Move MSVC runtime DLL code outside of MOZ_SYSTEM_NSPR block; r?glandium draft
authorGregory Szorc <gps@mozilla.com>
Thu, 17 Mar 2016 18:04:23 -0700
changeset 341913 e96cb95c3317931a5772bba85c1f04950c00ce4e
parent 341912 9a1d08876c93e133a1987b699308d1e2a8c01ae5
child 341914 72ea25566e52412362eb6828995fccf04fa23987
push id13322
push usergszorc@mozilla.com
push dateFri, 18 Mar 2016 01:12:32 +0000
reviewersglandium
bugs1257435
milestone48.0a1
Bug 1257435 - Move MSVC runtime DLL code outside of MOZ_SYSTEM_NSPR block; r?glandium Why it was the old way, I'm not sure. MozReview-Commit-ID: FMmDbZI0NqL
toolkit/mozapps/installer/upload-files.mk
--- a/toolkit/mozapps/installer/upload-files.mk
+++ b/toolkit/mozapps/installer/upload-files.mk
@@ -59,33 +59,34 @@ endif
 
 # JavaScript Shell packaging
 JSSHELL_BINS  = \
   js$(BIN_SUFFIX) \
   $(DLL_PREFIX)mozglue$(DLL_SUFFIX) \
   $(NULL)
 
 ifndef MOZ_SYSTEM_NSPR
-  ifdef MSVC_C_RUNTIME_DLL
-    JSSHELL_BINS += $(MSVC_C_RUNTIME_DLL)
-  endif
-  ifdef MSVC_CXX_RUNTIME_DLL
-    JSSHELL_BINS += $(MSVC_CXX_RUNTIME_DLL)
-  endif
   ifdef MOZ_FOLD_LIBS
     JSSHELL_BINS += $(DLL_PREFIX)nss3$(DLL_SUFFIX)
   else
     JSSHELL_BINS += \
       $(DLL_PREFIX)nspr4$(DLL_SUFFIX) \
       $(DLL_PREFIX)plds4$(DLL_SUFFIX) \
       $(DLL_PREFIX)plc4$(DLL_SUFFIX) \
       $(NULL)
   endif # MOZ_FOLD_LIBS
 endif # MOZ_SYSTEM_NSPR
 
+ifdef MSVC_C_RUNTIME_DLL
+  JSSHELL_BINS += $(MSVC_C_RUNTIME_DLL)
+endif
+ifdef MSVC_CXX_RUNTIME_DLL
+  JSSHELL_BINS += $(MSVC_CXX_RUNTIME_DLL)
+endif
+
 ifdef MOZ_SHARED_ICU
 ifeq ($(OS_TARGET), WINNT)
 JSSHELL_BINS += \
   icudt$(MOZ_ICU_DBG_SUFFIX)$(MOZ_ICU_VERSION).dll \
   icuin$(MOZ_ICU_DBG_SUFFIX)$(MOZ_ICU_VERSION).dll \
   icuuc$(MOZ_ICU_DBG_SUFFIX)$(MOZ_ICU_VERSION).dll \
   $(NULL)
 else