Bug 1257618 - Kill bogus "level should increase" when charging message r?snorp draft
authorAndrzej Hunt <ahunt@mozilla.com>
Thu, 17 Mar 2016 11:33:41 -0700
changeset 341771 56f2f51cb9866585cbb29b281518ee4b072f6886
parent 341770 07f0807c0e33f44d695c7cd9f23f4fd6f5dc207e
child 516451 af500cc41f940604a554ee419ad5b243b93ece42
push id13278
push userahunt@mozilla.com
push dateThu, 17 Mar 2016 18:34:11 +0000
reviewerssnorp
bugs1257618
milestone48.0a1
Bug 1257618 - Kill bogus "level should increase" when charging message r?snorp The battery level can decrease while we're trying to charge. Most commonly many devices oscillate between 99% and 100% when fully charged. This situation could also happen if the device is receiving less power than it's using. Therefore we shouldn't treat this as an extraordinary situation. MozReview-Commit-ID: eN3W9P5oty
mobile/android/base/java/org/mozilla/gecko/GeckoBatteryManager.java
--- a/mobile/android/base/java/org/mozilla/gecko/GeckoBatteryManager.java
+++ b/mobile/android/base/java/org/mozilla/gecko/GeckoBatteryManager.java
@@ -123,17 +123,16 @@ public class GeckoBatteryManager extends
                 if (sLastLevelChange != 0) {
                     // Use elapsedRealtime() because we want to track time across device sleeps.
                     long currentTime = SystemClock.elapsedRealtime();
                     long dt = (currentTime - sLastLevelChange) / 1000;
                     double dLevel = sLevel - previousLevel;
 
                     if (sCharging) {
                         if (dLevel < 0) {
-                            Log.w(LOGTAG, "When charging, level should increase!");
                             sRemainingTime = kUnknownRemainingTime;
                         } else {
                             sRemainingTime = Math.round(dt / dLevel * (1.0 - sLevel));
                         }
                     } else {
                         if (dLevel > 0) {
                             Log.w(LOGTAG, "When discharging, level should decrease!");
                             sRemainingTime = kUnknownRemainingTime;