Bug 1257435 - Package Universal CRT DLLs with jsshell; r?glandium draft
authorGregory Szorc <gps@mozilla.com>
Thu, 17 Mar 2016 15:19:30 -0700
changeset 341914 72ea25566e52412362eb6828995fccf04fa23987
parent 341913 e96cb95c3317931a5772bba85c1f04950c00ce4e
child 516493 9b94a76539066775bb9f45240c8db6db9fc3210f
push id13322
push usergszorc@mozilla.com
push dateFri, 18 Mar 2016 01:12:32 +0000
reviewersglandium
bugs1257435
milestone48.0a1
Bug 1257435 - Package Universal CRT DLLs with jsshell; r?glandium Builds with Visual Studio 2015 require the Universal CRT. While the universal CRT may be present on the target machine, there is no guarantee of this. So, we have to package these DLLs to ensure target machines are able to run js.exe. Similar code to what this commit adds exists in build/win32/Makefile.in. MozReview-Commit-ID: 8LIk1JlKLiT
toolkit/mozapps/installer/upload-files.mk
--- a/toolkit/mozapps/installer/upload-files.mk
+++ b/toolkit/mozapps/installer/upload-files.mk
@@ -77,16 +77,21 @@ endif # MOZ_SYSTEM_NSPR
 
 ifdef MSVC_C_RUNTIME_DLL
   JSSHELL_BINS += $(MSVC_C_RUNTIME_DLL)
 endif
 ifdef MSVC_CXX_RUNTIME_DLL
   JSSHELL_BINS += $(MSVC_CXX_RUNTIME_DLL)
 endif
 
+ifdef WIN_UCRT_REDIST_DIR
+  JSSHELL_BINS += $(notdir $(wildcard $(DIST)/bin/api-ms-win-*.dll))
+  JSSHELL_BINS += ucrtbase.dll
+endif
+
 ifdef MOZ_SHARED_ICU
 ifeq ($(OS_TARGET), WINNT)
 JSSHELL_BINS += \
   icudt$(MOZ_ICU_DBG_SUFFIX)$(MOZ_ICU_VERSION).dll \
   icuin$(MOZ_ICU_DBG_SUFFIX)$(MOZ_ICU_VERSION).dll \
   icuuc$(MOZ_ICU_DBG_SUFFIX)$(MOZ_ICU_VERSION).dll \
   $(NULL)
 else