Bug 1257434 - Remove MOZ_DEMANGLE_SYMBOLS and MOZ_COMPONENTS_VERSION_SCRIPT_LDFLAGS from js/src/old-configure.in draft
authorMike Hommey <mh+mozilla@glandium.org>
Thu, 17 Mar 2016 16:26:01 +0900
changeset 341571 c71b84fd052636250fa1badd5d271bd72bab2120
parent 341570 5417c7d8ecacbb278bcb3328c9a3813d451852eb
child 516415 4a259f4ce41c322c84f71f6497984b292c5c0945
push id13239
push userbmo:mh+mozilla@glandium.org
push dateThu, 17 Mar 2016 09:45:23 +0000
bugs1257434
milestone48.0a1
Bug 1257434 - Remove MOZ_DEMANGLE_SYMBOLS and MOZ_COMPONENTS_VERSION_SCRIPT_LDFLAGS from js/src/old-configure.in While not directly related to the others from this bug, I stumbled upon this while looking why there were references to MOZ_DMD in js/src/old-configure.in while it was never set there. MOZ_DEMANGLE_SYMBOLS is tied to MOZ_STACKWALKING, which is not set in js/src/old-configure.in. MOZ_COMPONENTS_VERSION_SCRIPT_LDFLAGS is specific to building XPCOM binary components, which there are none of under js/src.
js/src/old-configure.in
--- a/js/src/old-configure.in
+++ b/js/src/old-configure.in
@@ -1272,33 +1272,16 @@ case "$target" in
     ;;
 
 esac
 
 dnl Only one oddball right now (QNX), but this gives us flexibility
 dnl if any other platforms need to override this in the future.
 AC_DEFINE_UNQUOTED(D_INO,$DIRENT_INO)
 
-dnl ========================================================
-dnl = Flags to strip unused symbols from .so components
-dnl ========================================================
-case "$target" in
-    *-linux*|*-kfreebsd*-gnu|*-gnu*)
-        MOZ_COMPONENTS_VERSION_SCRIPT_LDFLAGS='-Wl,--version-script -Wl,$(BUILD_TOOLS)/gnu-ld-scripts/components-version-script'
-        ;;
-    *-darwin*)
-        MOZ_COMPONENTS_VERSION_SCRIPT_LDFLAGS='-Wl,-exported_symbols_list -Wl,$(BUILD_TOOLS)/gnu-ld-scripts/components-export-list'
-        ;;
-    *-mingw*)
-        if test -n "$GNU_CC"; then
-           MOZ_COMPONENTS_VERSION_SCRIPT_LDFLAGS='-Wl,--version-script,$(BUILD_TOOLS)/gnu-ld-scripts/components-version-script'
-        fi
-        ;;
-esac
-
 if test -z "$COMPILE_ENVIRONMENT"; then
     SKIP_COMPILER_CHECKS=1
     SKIP_LIBRARY_CHECKS=1
 fi
 
 dnl Configure JIT support
 
 case "$target" in
@@ -2454,24 +2437,16 @@ dnl = Support for demangling undefined s
 dnl ========================================================
 if test -z "$SKIP_LIBRARY_CHECKS"; then
     AC_LANG_SAVE
     AC_LANG_CPLUSPLUS
     AC_CHECK_FUNCS(__cxa_demangle, HAVE_DEMANGLE=1, HAVE_DEMANGLE=)
     AC_LANG_RESTORE
 fi
 
-# Demangle only for debug or DMD builds
-MOZ_DEMANGLE_SYMBOLS=
-if test "$HAVE_DEMANGLE" && test "$MOZ_DEBUG" -o "$MOZ_DMD"; then
-    MOZ_DEMANGLE_SYMBOLS=1
-    AC_DEFINE(MOZ_DEMANGLE_SYMBOLS)
-fi
-AC_SUBST(MOZ_DEMANGLE_SYMBOLS)
-
 dnl ========================================================
 dnl JIT observers
 dnl ========================================================
 
 MOZ_ARG_WITH_STRING(jitreport-granularity,
 [  --jitreport-granularity=N
                            Default granularity at which to report JIT code
                            to external tools
@@ -2675,20 +2650,16 @@ AC_SUBST(BUILD_CTYPES)
 if test "$JS_HAS_CTYPES"; then
   dnl Error out if we're on MSVC and MASM is unavailable.
   if test -n "$_MSC_VER" -a \( "$AS" != "ml.exe" -a "$AS" != "ml64.exe" \); then
     AC_MSG_ERROR([\"$AS\" is not a suitable assembler to build js-ctypes. If you are building with MS Visual Studio 8 Express, you may download the MASM 8.0 package, upgrade to Visual Studio 9 Express, or install the Vista SDK. Or do not use --enable-ctypes.])
   fi
   AC_DEFINE(JS_HAS_CTYPES)
 fi
 
-if test "$MOZ_DEBUG" -o "$MOZ_DMD"; then
-    MOZ_COMPONENTS_VERSION_SCRIPT_LDFLAGS=
-fi
-
 dnl ========================================================
 dnl =
 dnl = Options for generating the shell as a script
 dnl =
 dnl ========================================================
 
 MOZ_ARG_WITH_STRING(qemu-exe,
 [  --with-qemu-exe=path   Use path as an arm emulator on host platforms],
@@ -2727,17 +2698,16 @@ AC_SUBST(MOZ_DEBUG_LDFLAGS)
 AC_SUBST(WARNINGS_AS_ERRORS)
 AC_SUBST(LIBICONV)
 
 AC_SUBST(ENABLE_TESTS)
 
 AC_SUBST(ENABLE_STRIP)
 AC_SUBST(PKG_SKIP_STRIP)
 AC_SUBST(INCREMENTAL_LINKER)
-AC_SUBST(MOZ_COMPONENTS_VERSION_SCRIPT_LDFLAGS)
 
 AC_SUBST(MOZ_FIX_LINK_PATHS)
 
 AC_SUBST(MOZ_POST_PROGRAM_COMMAND)
 
 AC_SUBST(MOZ_APP_NAME)
 AC_SUBST(MOZ_APP_DISPLAYNAME)
 AC_SUBST(MOZ_APP_VERSION)