Bug 1257434 - Move --enable-jprof to moz.configure. r=ted
--- a/build/moz.configure/init.configure
+++ b/build/moz.configure/init.configure
@@ -256,16 +256,17 @@ def wanted_mozconfig_variables(help):
'EXTERNAL_SOURCE_DIR',
'GENISOIMAGE',
'L10NBASEDIR',
'MOZILLABUILD',
'MOZ_ARTIFACT_BUILDS',
'MOZ_BUILD_APP',
'MOZ_FMP4',
'MOZ_INSTRUMENT_EVENT_LOOP',
+ 'MOZ_JPROF',
'MOZ_USE_SYSTRACE',
'MOZTTDIR',
'PERL',
'RPMBUILD',
'TAR',
'UNZIP',
'USE_FC_FREETYPE',
'WITHOUT_X',
--- a/build/moz.configure/old.configure
+++ b/build/moz.configure/old.configure
@@ -211,17 +211,16 @@ def old_configure_options(*options):
'--enable-icf',
'--enable-install-strip',
'--enable-instruments',
'--enable-ion',
'--enable-ios-target',
'--enable-ipdl-tests',
'--enable-jemalloc',
'--enable-jitspew',
- '--enable-jprof',
'--enable-libjpeg-turbo',
'--enable-libproxy',
'--enable-llvm-hacks',
'--enable-logrefcnt',
'--enable-macos-target',
'--enable-maintenance-service',
'--enable-media-navigator',
'--enable-memory-sanitizer',
--- a/js/src/old-configure.in
+++ b/js/src/old-configure.in
@@ -2334,23 +2334,18 @@ AC_SUBST(JS_CODEGEN_NONE)
AC_SUBST(JS_DISASM_ARM)
AC_SUBST(ASMJS_MAY_USE_SIGNAL_HANDLERS)
AC_SUBST(ASMJS_MAY_USE_SIGNAL_HANDLERS_FOR_OOB)
AC_SUBST(ASMJS_MAY_USE_SIGNAL_HANDLERS_FOR_UNALIGNED)
dnl ========================================================
dnl jprof
dnl ========================================================
-MOZ_ARG_ENABLE_BOOL(jprof,
-[ --enable-jprof Enable jprof profiling tool (needs mozilla/tools/jprof). Implies --enable-profiling.],
- MOZ_JPROF=1,
- MOZ_JPROF= )
if test -n "$MOZ_JPROF"; then
MOZ_PROFILING=1
- AC_DEFINE(MOZ_JPROF)
fi
dnl ========================================================
dnl instruments
dnl ========================================================
MOZ_ARG_ENABLE_BOOL(instruments,
[ --enable-instruments Enable instruments remote profiling. Implies --enable-profiling.],
MOZ_INSTRUMENTS=1,
@@ -2782,17 +2777,16 @@ AC_SUBST(MC)
AC_SUBST(WINDRES)
AC_SUBST(IMPLIB)
AC_SUBST(FILTER)
AC_SUBST(BIN_FLAGS)
AC_SUBST(MOZ_DEBUG)
AC_SUBST(MOZ_DEBUG_SYMBOLS)
AC_SUBST(MOZ_DEBUG_LDFLAGS)
AC_SUBST(WARNINGS_AS_ERRORS)
-AC_SUBST(MOZ_JPROF)
AC_SUBST(MOZ_INSTRUMENTS)
AC_SUBST(MOZ_CALLGRIND)
AC_SUBST(MOZ_VTUNE)
AC_SUBST(MOZ_PROFILING)
AC_SUBST(LIBICONV)
AC_SUBST(ENABLE_TESTS)
--- a/old-configure.in
+++ b/old-configure.in
@@ -1207,23 +1207,18 @@ if test -n "$MOZ_VALGRIND"; then
[--enable-valgrind specified but Valgrind is not installed]))
AC_DEFINE(MOZ_VALGRIND)
fi
AC_SUBST(MOZ_VALGRIND)
dnl ========================================================
dnl jprof
dnl ========================================================
-MOZ_ARG_ENABLE_BOOL(jprof,
-[ --enable-jprof Enable jprof profiling tool (needs mozilla/tools/jprof). Implies --enable-profiling.],
- MOZ_JPROF=1,
- MOZ_JPROF= )
if test -n "$MOZ_JPROF"; then
MOZ_PROFILING=1
- AC_DEFINE(MOZ_JPROF)
fi
dnl ========================================================
dnl SPS Profiler
dnl ========================================================
MOZ_ENABLE_PROFILER_SPS=1
case "${OS_TARGET}" in
@@ -7432,17 +7427,16 @@ AC_SUBST(BIN_FLAGS)
AC_SUBST(MOZ_AUTH_EXTENSION)
AC_SUBST(MOZ_PREF_EXTENSIONS)
AC_SUBST(MOZ_DEBUG)
AC_SUBST(MOZ_DEBUG_SYMBOLS)
AC_SUBST(MOZ_DEBUG_LDFLAGS)
AC_SUBST(WARNINGS_AS_ERRORS)
AC_SUBST_SET(MOZ_EXTENSIONS)
AC_SUBST(MOZ_ENABLE_PROFILER_SPS)
-AC_SUBST(MOZ_JPROF)
AC_SUBST(MOZ_INSTRUMENTS)
AC_SUBST(MOZ_CALLGRIND)
AC_SUBST(MOZ_VTUNE)
AC_SUBST(MOZ_PROFILING)
AC_SUBST(LIBICONV)
AC_SUBST(MOZ_PLACES)
AC_SUBST(MOZ_SOCIAL)
AC_SUBST(MOZ_TOOLKIT_SEARCH)
--- a/toolkit/moz.configure
+++ b/toolkit/moz.configure
@@ -16,16 +16,27 @@ option('--enable-systrace', env='MOZ_USE
def systrace(value, target):
if value and target.os != 'Android':
error('--enable-systrace cannot be used when targetting %s'
% target.os)
if value:
set_define('MOZ_USE_SYSTRACE', '1')
+option('--enable-jprof', env='MOZ_JPROF',
+ help='Enable jprof profiling tool (needs mozilla/tools/jprof)')
+
+@depends('--enable-jprof')
+def jprof(value):
+ if value:
+ set_config('MOZ_JPROF', '1')
+ set_define('MOZ_JPROF', '1')
+ add_old_configure_assignment('MOZ_JPROF', '1')
+
+
# Javascript engine
# ==============================================================
include('../js/moz.configure')
# L10N
# ==============================================================
option('--with-l10n-base', nargs=1, env='L10NBASEDIR',