Bug 1257325 - Disable C4838 to unblock compilation on VS2015; r?rbarnes
As part of unblocking building with VS2015u1 in automation, I'm mass
disabling compiler warnings that are turned into errors. This is not
the preferred mechanism to fix compilation warnings. So hopefully
this patch never lands because someone insists on fixing the underlying
problem instead. But if it does land, hopefully the workaround is
only temporary.
MozReview-Commit-ID: 6UrAbeEAxLc
--- a/dom/crypto/moz.build
+++ b/dom/crypto/moz.build
@@ -26,9 +26,16 @@ include('/ipc/chromium/chromium-config.m
FINAL_LIBRARY = 'xul'
LOCAL_INCLUDES += [
'/security/manager/ssl',
'/security/pkix/include',
'/xpcom/build',
]
+if CONFIG['_MSC_VER']:
+ # This is intended as a temporary workaround to enable building warning
+ # free on Visual Studio 2015.
+ # conversion from 'nsTArray_base<Alloc,nsTArray_CopyChooser<E>::Type>::size_type' to
+ # 'CK_ULONG' requires a narrowing conversion
+ CXXFLAGS += ['-wd4838']
+
MOCHITEST_MANIFESTS += ['test/mochitest.ini']