Bug 1257320 - Disable C4577 to unblock compilation on VS2015; r?mayhemer draft
authorGregory Szorc <gps@mozilla.com>
Wed, 16 Mar 2016 14:04:34 -0700
changeset 341303 45bb219aa30b23605704e9c53656e2b4fabefa0c
parent 341302 6c6c97a866cb3157466c3a15f7c477f9a11122c2
child 516376 166fb5c722d81a78f1dbb29cff18ae1879bf05a4
push id13183
push usergszorc@mozilla.com
push dateWed, 16 Mar 2016 21:05:20 +0000
reviewersmayhemer
bugs1257320
milestone48.0a1
Bug 1257320 - Disable C4577 to unblock compilation on VS2015; r?mayhemer As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists of fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. That being said, the warnings this patch masks are in an included ICU header, which is a 3rd party project. So our hands appear tied. MozReview-Commit-ID: 1Qh9H3zrCDf
netwerk/dns/moz.build
--- a/netwerk/dns/moz.build
+++ b/netwerk/dns/moz.build
@@ -74,8 +74,15 @@ if CONFIG['ENABLE_INTL_API']:
     CXXFLAGS += CONFIG['MOZ_ICU_CFLAGS']
     CFLAGS += CONFIG['MOZ_ICU_CFLAGS']
     LOCAL_INCLUDES += CONFIG['MOZ_ICU_INCLUDES']
     USE_LIBS += ['icu']
 else:
     UNIFIED_SOURCES += [
         'nameprep.c',
     ]
+
+if CONFIG['_MSC_VER']:
+    # This is intended as a temporary hack to support building with VS2015.
+    # icu\source\common\unicode/ucasemap.h(93): warning C4577:
+    # 'noexcept' used with no exception handling mode specified;
+    # termination on exception is not guaranteed. Specify /EHsc from unified dns
+    CXXFLAGS += ['-wd4577']