Bug 1257305 - Disable C4312 to unblock compilation on VS2015; r?jld draft
authorGregory Szorc <gps@mozilla.com>
Wed, 16 Mar 2016 13:11:50 -0700
changeset 341439 75da0ef425caebf1cb395464f3e13a164ed07786
parent 341438 becbfbaba3a9d433ed9f3174f79ec1a5bb7c7e02
child 516396 1ce1fb36676c7118a9543524fb1f567532939af2
push id13210
push usergszorc@mozilla.com
push dateThu, 17 Mar 2016 00:24:29 +0000
reviewersjld
bugs1257305
milestone48.0a1
Bug 1257305 - Disable C4312 to unblock compilation on VS2015; r?jld As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists on fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. MozReview-Commit-ID: KfumV9jas6s
ipc/chromium/moz.build
--- a/ipc/chromium/moz.build
+++ b/ipc/chromium/moz.build
@@ -167,8 +167,14 @@ if '86' not in ost and 'arm' not in ost 
         'src/base/atomicops_internals_mutex.cc',
     ]
 
 CXXFLAGS += CONFIG['TK_CFLAGS']
 
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'
+
+if CONFIG['_MSC_VER']:
+    # This is intended as a temporary workaround to enable building with VS2015.
+    # src/base/thread_local.h(110): warning C4312: 'reinterpret_cast':
+    # conversion from 'int' to 'void *' of greater size
+    CXXFLAGS += ['-wd4312']