Bug 1257040 - Disable C4577 to unblock compilation on VS2015; r?jorendorff draft
authorGregory Szorc <gps@mozilla.com>
Mon, 14 Mar 2016 23:23:34 -0700
changeset 340804 2631292cd42fc3edebe25b8edf97247a95ebfcfe
parent 340803 be593f6ea16bc63b8005cc820718870022933edd
child 516278 f717db2fe262af523ac95137d9ecc03de46b9c43
push id13072
push usergszorc@mozilla.com
push dateWed, 16 Mar 2016 00:55:34 +0000
reviewersjorendorff
bugs1257040
milestone48.0a1
Bug 1257040 - Disable C4577 to unblock compilation on VS2015; r?jorendorff As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists of fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. That being said, the warnings this patch masks are in an included ICU header, which is a 3rd party project. So our hands appear tied. MozReview-Commit-ID: FHzp6v5yUKG
js/src/moz.build
--- a/js/src/moz.build
+++ b/js/src/moz.build
@@ -657,16 +657,21 @@ if CONFIG['_MSC_VER']:
     # instantiation request") is emitted for all Parser methods that
     # have a Parser<FullParseHandler> definition but no
     # Parser<SyntaxParseHandler> definition, see bug 1167030.
     CXXFLAGS += ['-wd4661']
     CXXFLAGS += ['-we4067', '-we4258', '-we4275']
     CXXFLAGS += ['-wd4146'] # FIXME: unary minus operator applied to unsigned type (bug 1229189)
     CXXFLAGS += ['-wd4273'] # FIXME: inconsistent dll linkage (bug 1229666)
 
+    # This is intended as a temporary hack to support building with VS2015.
+    # 'noexcept' used with no exception handling mode specified;
+    # termination on exception is not guaranteed. Specify /EHsc
+    CXXFLAGS += ['-wd4577']
+
 if CONFIG['OS_ARCH'] not in ('WINNT', 'HP-UX'):
     OS_LIBS += [
         'm',
     ]
 
 if CONFIG['OS_ARCH'] == 'FreeBSD':
     OS_LIBS += [
         '-pthread',