Bug 1257036 - Disable C4302 to unblock compilation on VS2015; r?bobowen draft
authorGregory Szorc <gps@mozilla.com>
Wed, 16 Mar 2016 13:27:59 -0700
changeset 341260 21960de1e6b8cdc92e352075a52f7fb63c571bfd
parent 341233 16ad4bb673f21600a494229d3bea288c8c4a0717
child 341261 b850a14c62217d1c21500a676cec197c6cd3d8ec
push id13178
push usergszorc@mozilla.com
push dateWed, 16 Mar 2016 20:31:35 +0000
reviewersbobowen
bugs1257036
milestone48.0a1
Bug 1257036 - Disable C4302 to unblock compilation on VS2015; r?bobowen As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. But the warning occurs in third party code, so my hands are tied. MozReview-Commit-ID: A0UF2RHJzVo
security/sandbox/staticruntime/moz.build
--- a/security/sandbox/staticruntime/moz.build
+++ b/security/sandbox/staticruntime/moz.build
@@ -27,10 +27,11 @@ if CONFIG['OS_ARCH'] == 'WINNT':
     DISABLE_STL_WRAPPING = True
 
     # Suppress warnings in third-party code.
     if CONFIG['_MSC_VER']:
         CXXFLAGS += [
             '-wd4275', # non dll-interface class exception used as base for dll-interface class
             '-wd4717', # recursive on all control paths, function will cause runtime stack overflow
             '-wd4996', # 'GetVersionExW': was declared deprecated
+            '-wd4302', # 'reinterpret_cast': truncation from 'LPCSTR' to 'WORD'
             '-wd4312', # 'reinterpret_cast': conversion from 'DWORD' to 'LPOVERLAPPED' of greater size
         ]