Bug 1256978. Use self.capabilities instead of self._capabilities in BaseMarionetteTestRunner; r?maja_zf draft
authorNathalie Rud <nathalier@gmail.com>
Wed, 16 Mar 2016 01:40:21 +0200
changeset 340862 670f65f0655a8bf4a4158bf3fa6bbeeb7c2dd112
parent 340742 edc3c27c9299708a877848d6026689a10a7a8a34
child 516285 1de83dd1b27378ff580f9d5dfca05a168116658e
push id13080
push userbmo:nathalier@gmail.com
push dateWed, 16 Mar 2016 02:27:05 +0000
reviewersmaja_zf
bugs1256978
milestone48.0a1
Bug 1256978. Use self.capabilities instead of self._capabilities in BaseMarionetteTestRunner; r?maja_zf MozReview-Commit-ID: 9ZCOLKae6rt
testing/marionette/harness/marionette/runner/base.py
--- a/testing/marionette/harness/marionette/runner/base.py
+++ b/testing/marionette/harness/marionette/runner/base.py
@@ -803,22 +803,19 @@ setReq.onerror = function() {
 
     def run_tests(self, tests):
         self.reset_test_stats()
         self.start_time = time.time()
 
         need_external_ip = True
         if not self.marionette:
             self.start_marionette()
-            # Retrieve capabilities for later use
-            if not self._capabilities:
-                self.capabilities
             # if we're working against a desktop version, we usually don't need
             # an external ip
-            if self._capabilities['device'] == "desktop":
+            if self.capabilities['device'] == "desktop":
                 need_external_ip = False
         self.logger.info('Initial Profile Destination is '
                          '"{}"'.format(self.marionette.profile_path))
 
         # Gaia sets server_root and that means we shouldn't spin up our own httpd
         if not self.httpd:
             if self.server_root is None or os.path.isdir(self.server_root):
                 self.logger.info("starting httpd")