Bug 1256750 - Disable C4474 to unblock compilation on VS2015; r?jesup draft
authorGregory Szorc <gps@mozilla.com>
Tue, 15 Mar 2016 14:49:13 -0700
changeset 340741 1340357d52c966735223b1e4ad8692ac60937a58
parent 340740 8775bfb709245429e5a35ff4412fd554c65b1b88
child 340765 ecdcf0a7cf7d8e1967f5e83adfd8d856f90e3227
push id13049
push usergszorc@mozilla.com
push dateTue, 15 Mar 2016 22:29:44 +0000
reviewersjesup
bugs1256750
milestone48.0a1
Bug 1256750 - Disable C4474 to unblock compilation on VS2015; r?jesup This is similar to the previous patch except it applies to our C++ in tree as opposed to the GYP config. The same issue with the same header is encountered. MozReview-Commit-ID: 6ovXwHLJUxk
dom/media/webrtc/moz.build
media/webrtc/signaling/test/moz.build
--- a/dom/media/webrtc/moz.build
+++ b/dom/media/webrtc/moz.build
@@ -89,10 +89,11 @@ if CONFIG['GNU_CC'] or CONFIG['CLANG_CL'
 
 FINAL_LIBRARY = 'xul'
 
 if CONFIG['_MSC_VER']:
     CXXFLAGS += [
         '-wd4275', # non dll-interface class used as base for dll-interface class
         '-wd4312', # This is intended as a temporary hack to support building with VS2015
                    # 'reinterpret_cast': conversion from 'DWORD' to 'HANDLE' of greater size
+        '-wd4474', # 'sscanf_s' : too many arguments passed for format string
     ]
     DEFINES['__PRETTY_FUNCTION__'] = '__FUNCSIG__'
--- a/media/webrtc/signaling/test/moz.build
+++ b/media/webrtc/signaling/test/moz.build
@@ -19,8 +19,10 @@ if CONFIG['OS_TARGET'] != 'WINNT' and CO
 include('/ipc/chromium/chromium-config.mozbuild')
 include('common.build')
 
 USE_LIBS += [
     '/media/webrtc/signalingtest/signaling_ecc/ecc',
     'mtransport_s',
 ]
 
+if CONFIG['_MSC_VER']:
+    CXXFLAGS += ['-wd4474']