Bug 1256750 - Disable C4474 to unblock compilation on VS2015; r?jesup
As part of unblocking building with VS2015u1 in automation, I'm mass
disabling compiler warnings that are turned into errors. This is not
the preferred mechanism to fix compilation warnings, obviously. However,
this warning occurs in 3rd party WebRTC code, so our hands are somewhat
tied. There is precedence for allowing compiler warnings in other
WebRTC projects. I guess signaling was just lucky in that it had none.
MozReview-Commit-ID: HKamnA3X3lQ
--- a/media/webrtc/moz.build
+++ b/media/webrtc/moz.build
@@ -90,16 +90,19 @@ if CONFIG['MOZ_WEBRTC_SIGNALING']:
'signaling/src/sdp/sipcc/sdp_main.c',
'signaling/src/sdp/sipcc/sdp_services_unix.c',
'signaling/src/sdp/sipcc/sdp_token.c',
'signaling/src/sdp/sipcc/sdp_utils.c',
]
GYP_DIRS['signaling'].non_unified_sources += signaling_non_unified_sources
+ if CONFIG['_MSC_VER']:
+ GYP_DIRS['signaling'].sandbox_vars['ALLOW_COMPILER_WARNINGS'] = True
+
if CONFIG['MOZ_WIDGET_TOOLKIT'] != 'gonk':
GYP_DIRS += ['trunk/testing']
GYP_DIRS['trunk/testing'].input = 'trunk/testing/gtest.gyp'
GYP_DIRS['trunk/testing'].variables = gyp_vars
# We allow warnings for third-party code that can be updated from upstream.
GYP_DIRS['trunk/testing'].sandbox_vars['ALLOW_COMPILER_WARNINGS'] = True
GYP_DIRS['trunk/testing'].non_unified_sources += webrtc_non_unified_sources
@@ -108,8 +111,11 @@ if CONFIG['MOZ_WIDGET_TOOLKIT'] != 'gonk
GYP_DIRS['signalingtest'].input = 'signaling/signaling.gyp'
GYP_DIRS['signalingtest'].variables = gyp_vars.copy()
GYP_DIRS['signalingtest'].variables.update(
build_for_test=1,
moz_webrtc_mediacodec=0,
build_for_standalone=0
)
GYP_DIRS['signalingtest'].non_unified_sources += signaling_non_unified_sources
+
+ if CONFIG['_MSC_VER']:
+ GYP_DIRS['signalingtest'].sandbox_vars['ALLOW_COMPILER_WARNINGS'] = True