Bug 1256514 - Disable C4577 to unblock compilation on VS2015; r?poiru draft
authorGregory Szorc <gps@mozilla.com>
Mon, 14 Mar 2016 18:41:48 -0700
changeset 340228 4a75cd1a15ef3c5c4166aaa793902d352bb29821
parent 340227 12d96c9dc375d5ab612fc5208a6d3d4158ce7e8f
child 340229 a9665df0c4d7f267694ee8b7bb8ce59ce50e663a
push id12918
push usergszorc@mozilla.com
push dateTue, 15 Mar 2016 01:42:04 +0000
reviewerspoiru
bugs1256514
milestone48.0a1
Bug 1256514 - Disable C4577 to unblock compilation on VS2015; r?poiru As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists of fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. That being said, the warning occurs in 3rd party ICU code. So I'm not sure what my options are for fixing this. MozReview-Commit-ID: 9gOSotjaQsN
intl/unicharutil/util/internal/moz.build
--- a/intl/unicharutil/util/internal/moz.build
+++ b/intl/unicharutil/util/internal/moz.build
@@ -18,8 +18,14 @@ LOCAL_INCLUDES += [
     '..',
 ]
 
 if CONFIG['ENABLE_INTL_API']:
     CXXFLAGS += CONFIG['MOZ_ICU_CFLAGS']
     LOCAL_INCLUDES += CONFIG['MOZ_ICU_INCLUDES']
 
 DIST_INSTALL = True
+
+if CONFIG['_MSC_VER']:
+    # This is intended as a temporary hack to support building with VS2015.
+    # 'noexcept' used with no exception handling mode specified;
+    # termination on exception is not guaranteed. Specify /EHsc
+    CXXFLAGS += ['-wd4577']