Bug 1256509 - Disable C4577 to unblock compilation on VS2015; r?poiru draft
authorGregory Szorc <gps@mozilla.com>
Mon, 14 Mar 2016 18:03:39 -0700
changeset 340184 d83a7b09bde85b2a66d36d2af500281f4a9b4a84
parent 340183 40070b35e02aca4ceb58d1d05229b065dc22c2bf
child 516146 1be2497d9b94965e038ff678d440726de26891de
push id12913
push usergszorc@mozilla.com
push dateTue, 15 Mar 2016 01:03:59 +0000
reviewerspoiru
bugs1256509
milestone48.0a1
Bug 1256509 - Disable C4577 to unblock compilation on VS2015; r?poiru As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists of fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. That being said, the warning occurs in 3rd party ICU code. So I'm not sure what my options are for fixing this. MozReview-Commit-ID: 2MIqvI3qCsZ
layout/forms/moz.build
--- a/layout/forms/moz.build
+++ b/layout/forms/moz.build
@@ -53,8 +53,14 @@ LOCAL_INCLUDES += [
     '/dom/html',
 ]
 
 if CONFIG['ENABLE_INTL_API']:
     # nsNumberControlFrame.cpp requires ICUUtils.h which in turn requires
     # i18n/unum.h
     CXXFLAGS += CONFIG['MOZ_ICU_CFLAGS']
     LOCAL_INCLUDES += CONFIG['MOZ_ICU_INCLUDES']
+
+if CONFIG['_MSC_VER']:
+    # This is intended as a temporary hack to support building with VS2015.
+    # 'noexcept' used with no exception handling mode specified;
+    # termination on exception is not guaranteed. Specify /EHsc
+    CXXFLAGS += ['-wd4577']